You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Celestia is considering decreasing auth.MaxMemoCharacters from 256 to 16 (see celestiaorg/CIPs#44). While working on that proposal, I observed that a number of the most frequent memos are relayer memos of the form:
The above memo is 64 characters so if the linked Celestia improvement proposal (CIP) is approved, memos of this format will be considered invalid. Put another way, Hermes relayers that are relaying transactions on Celestia will stop relaying.
Proposal
I noticed that Hermes config allows users to specify a portion of the memo. Ref:
# Specify a string that Hermes will use as a memo for each transaction it submits
# to this chain. The string is limited to 50 characters. Default: '' (empty).
# Note: Hermes will append to the string defined here additional
# operational debugging information, e.g., relayer build version.
memo_prefix = ''
However, this option doesn't enable relayers to override the entire memo. Since the 16 character memo limitation is Celestia-specific, proposal to modify the mechanics around this chain-specific config.
Option A (non-breaking)
I think it would be non-breaking to add a new chain-specific config for the memo field.
If memo is provided, it sets the entire memo. The value specified by memo_prefix is ignored. No relayer build information is suffixed to this memo.
If memo isn't provided, the current behavior is respected.
This approach would enable relayers to continue operating on Celestia.
Option B (breaking)
If maintainers are open to breaking existing behavior and would like to preserve the diagnostic information in the memo, consider reducing the suffix to just the version + commit hash portion. E.g. 1.7.4+ab73266 which is only 13 characters.
If users don't specify a memo_prefix, default to the version + commit hash portion.
If users do specify a memo_prefix, don't suffix with version + commit hash portion.
If this option is taken, it's probably worth renaming memo_prefix => memo as well.
Acceptance Criteria
TBD. Opening an issue to start the discussion.
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate milestone (priority) applied
Appropriate contributors tagged
Contributor assigned/self-assigned
The text was updated successfully, but these errors were encountered:
Summary
Consider offering a chain-specific
memo
configProblem Definition
Celestia is considering decreasing
auth.MaxMemoCharacters
from 256 to 16 (see celestiaorg/CIPs#44). While working on that proposal, I observed that a number of the most frequent memos are relayer memos of the form:The above memo is 64 characters so if the linked Celestia improvement proposal (CIP) is approved, memos of this format will be considered invalid. Put another way, Hermes relayers that are relaying transactions on Celestia will stop relaying.
Proposal
I noticed that Hermes config allows users to specify a portion of the memo. Ref:
However, this option doesn't enable relayers to override the entire memo. Since the 16 character memo limitation is Celestia-specific, proposal to modify the mechanics around this chain-specific config.
Option A (non-breaking)
I think it would be non-breaking to add a new chain-specific config for the
memo
field.memo
is provided, it sets the entire memo. The value specified bymemo_prefix
is ignored. No relayer build information is suffixed to thismemo
.memo
isn't provided, the current behavior is respected.This approach would enable relayers to continue operating on Celestia.
Option B (breaking)
If maintainers are open to breaking existing behavior and would like to preserve the diagnostic information in the memo, consider reducing the suffix to just the version + commit hash portion. E.g.
1.7.4+ab73266
which is only 13 characters.If users don't specify a
memo_prefix
, default to the version + commit hash portion.If users do specify a
memo_prefix
, don't suffix with version + commit hash portion.If this option is taken, it's probably worth renaming
memo_prefix
=>memo
as well.Acceptance Criteria
TBD. Opening an issue to start the discussion.
For Admin Use
The text was updated successfully, but these errors were encountered: