Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use packet_ack_hex event attribute instead of deprecated packet_ack attribute to decode WriteAck event #3922

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

romac
Copy link
Member

@romac romac commented Mar 27, 2024

Closes: #3921


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac requested a review from ljoss17 March 27, 2024 08:46
Copy link
Contributor

@ljoss17 ljoss17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@romac romac merged commit 5e49554 into master Apr 2, 2024
35 checks passed
@romac romac deleted the romac/packet-ack-hex branch April 2, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use packet_ack_hex attribute instead of deprecated packet_ack attribute to decode WriteAck event
2 participants