Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cargo-doc build on nightly #3967

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Fix cargo-doc build on nightly #3967

merged 1 commit into from
Apr 22, 2024

Conversation

romac
Copy link
Member

@romac romac commented Apr 22, 2024

Closes: #XXX

Description

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac enabled auto-merge April 22, 2024 09:21
@romac romac disabled auto-merge April 22, 2024 09:22
@romac romac enabled auto-merge April 22, 2024 09:22
@romac romac requested a review from ljoss17 April 22, 2024 09:22
@romac romac disabled auto-merge April 22, 2024 09:51
@romac romac merged commit f71c409 into master Apr 22, 2024
31 checks passed
@romac romac deleted the romac/fix-nightly branch April 22, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljoss17 ljoss17 Awaiting requested review from ljoss17

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@romac