-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split packet clearing schedule from packet worker #4080
Merged
ljoss17
merged 19 commits into
master
from
luca_joss/split-packet-clearing-schedule-from-packet-worker
Aug 6, 2024
Merged
Split packet clearing schedule from packet worker #4080
ljoss17
merged 19 commits into
master
from
luca_joss/split-packet-clearing-schedule-from-packet-worker
Aug 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom-packet-worker
…rom-packet-worker
…rom-packet-worker
romac
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Left a couple nits
Co-authored-by: Romain Ruetschi <romain@informal.systems> Signed-off-by: Luca Joss <43531661+ljoss17@users.noreply.github.com>
…rom-packet-worker
ljoss17
deleted the
luca_joss/split-packet-clearing-schedule-from-packet-worker
branch
August 6, 2024 12:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4071
Description
This PR removes the packet clearing logic from the
packet_cmd_worker
.The reason is to avoid blocking the worker if there is a huge amount of pending packets.
The
packet_cmd_worker
will not handle packet clearing anymore, instead an additional background task,clear_cmd_worker
will schedule pending packets to be cleared. And the packets will be cleared by the whenhandle_execute_schedule
is called.A new configuration
clear_limit
is added in order to only clear up to a maximum ofn
packets every time clearing is triggered. The default value is50
.There is an exception for Ordered channels, in which case the clearing is blocking and is done before relaying. This is because relaying without completing the packet clearing before would fail due to an incorrect packet sequence error.
PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.