Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ibc-go v9 to chains running tests in CI #4152

Merged
merged 7 commits into from
Aug 15, 2024

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Aug 14, 2024

Closes: #4151

Description

This PR adds ibc-go v9.0.0-beta.1 to the matrix of chains running the tests in the CI.

Disable denom trace test with ibc-go v9 since the gRPC query DenomTrace has been replaced with queries Denom and Denoms, https://github.com/cosmos/ibc-go/blob/release/v9.0.x/modules/apps/transfer/keeper/grpc_query.go#L27-L80.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@ljoss17 ljoss17 requested a review from romac August 15, 2024 09:30
@ljoss17 ljoss17 marked this pull request as ready for review August 15, 2024 09:30
@romac
Copy link
Member

romac commented Aug 15, 2024

Thanks!

@ljoss17 ljoss17 added this pull request to the merge queue Aug 15, 2024
Merged via the queue into master with commit 0d3b57c Aug 15, 2024
29 checks passed
@ljoss17 ljoss17 deleted the luca_joss/add-ibc-go-v9-to-ci branch August 15, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ibc-go v9 to integration tests
2 participants