-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump prost
to v0.13 and tonic
to v0.12
#1444
Conversation
Updates these dependencies to their latest versions. Protos have not been regenerated using the latest `prost-build`/`tonic-build` however seem to be compatible.
Well great, I didn't try regenerating the protos as noted in the description/commit message, but it seems if you do regenerate them they no longer compile per the |
The core problem seems to be that I'm not sure why this change was made. It's a simple struct with two public fields which are themselves |
Sidebar: in See discussion here: cosmos/cosmos-rust#459 (review) |
That's already what we are already doing in tendermint-rs, see the generated code here: https://github.com/informalsystems/tendermint-rs/blob/main/proto/src/protobuf.rs These types never implemented |
We should probably generate code for all Otherwise one cannot pass a What do you think? |
@romac sounds good to me! Seems like the first step towards unifying protos between I'd just ask to retain |
This comment was marked as resolved.
This comment was marked as resolved.
Yes good idea! Let's do all this in a separate PR. |
prost
to v0.13; tonic
to v0.12prost
to v0.13 and tonic
to v0.12
prost
to v0.13 and tonic
to v0.12prost
to v0.13 and tonic
to v0.12
@romac I didn't put |
prost
to v0.13 and tonic
to v0.12prost
to v0.13 and tonic
to v0.12
Updates these dependencies to their latest versions.
Protos have not been regenerated using the latest
prost-build
/tonic-build
however seem to be compatible.See also: #1442