Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (RPC) integration tests #95

Closed
wants to merge 4 commits into from
Closed

Fix (RPC) integration tests #95

wants to merge 4 commits into from

Commits on Dec 12, 2019

  1. fix /abci_info & /genesis: 

     - add app_version & use #[serde(default)] to deal with omitted fields in JSON
 - make app_state in /genesis reply optional
 - fix string in abci_info test (kvstore wont reply with "GaiaApp")

 verify tests pass via running `tendermint node --proxy_app=kvstore` and
 `cargo test -- --nocapture --ignored
    @liamsi
    liamsi committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    87e888b View commit details
    Browse the repository at this point in the history

  2. add back ignore for /genesis

    @liamsi
    liamsi committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    ef4a83f View commit details
    Browse the repository at this point in the history

  3. #[serde(default)] does the trick for a missing field (no need 

    for an additional Option<> around a skipped field (due to omitempty)
    @liamsi
    liamsi committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    a7b9782 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2020

  1. Merge branch 'master' into fix_integration_tests

    @liamsi
    liamsi authored Mar 13, 2020
    Configuration menu
    Copy the full SHA
    0586471 View commit details
    Browse the repository at this point in the history