From ef8beb8d0c7d481b8f3f3a47d48695889e4079b3 Mon Sep 17 00:00:00 2001 From: ImmanuelSegol <3ditds@gmail.com> Date: Wed, 20 Sep 2023 12:06:10 +0000 Subject: [PATCH] remove some --- .github/workflows/dev-pr.yml | 4 ---- .github/workflows/main-build.yml | 1 - .github/workflows/main-test.yml | 3 --- Cargo.toml | 2 +- 4 files changed, 1 insertion(+), 9 deletions(-) diff --git a/.github/workflows/dev-pr.yml b/.github/workflows/dev-pr.yml index d418ba3d9..1e66197a5 100644 --- a/.github/workflows/dev-pr.yml +++ b/.github/workflows/dev-pr.yml @@ -70,9 +70,6 @@ jobs: run: | export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$(pwd)/goicicle go test ./goicicle/curves/bn254 -count=1 - # TODO: Fix tests for bls12377 - # TODO: Fix tests for bls12381 - # run: go test ./goicicle/curves/bn254 ./goicicle/curves/bls12377 ./goicicle/curves/bls12381 -count=1 formatting-golang: name: Check Golang Code Formatting @@ -83,7 +80,6 @@ jobs: - name: Check gofmt run: if [[ $(go list ./... | xargs go fmt) ]]; then echo "Please run go fmt"; exit 1; fi - # TODO: Add once Golang make file supports building for Windows # build-golang-windows: # name: Build Golang on Windows # runs-on: windows-2022 diff --git a/.github/workflows/main-build.yml b/.github/workflows/main-build.yml index d70604836..cecd084f1 100644 --- a/.github/workflows/main-build.yml +++ b/.github/workflows/main-build.yml @@ -45,7 +45,6 @@ jobs: run: make all working-directory: ./goicicle - # TODO: Add once Golang make file supports building for Windows # build-golang-windows: # name: Build Golang on Windows # runs-on: windows-2022 diff --git a/.github/workflows/main-test.yml b/.github/workflows/main-test.yml index f616461f5..acdecaf5c 100644 --- a/.github/workflows/main-test.yml +++ b/.github/workflows/main-test.yml @@ -32,6 +32,3 @@ jobs: run: | export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$(pwd)/goicicle go test ./goicicle/curves/bn254 -count=1 - # TODO: Fix tests for bls12377 - # TODO: Fix tests for bls12381 - # run: go test ./goicicle/curves/bn254 ./goicicle/curves/bls12377 ./goicicle/curves/bls12381 -count=1 diff --git a/Cargo.toml b/Cargo.toml index 6844bf701..0c68d0f38 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -35,7 +35,7 @@ rustacuda = "0.1" rustacuda_core = "0.1" rustacuda_derive = "0.1" -rand = "*" #TODO: move rand and ark dependencies to dev once random scalar/point generation is done "natively" +rand = "*" [build-dependencies] cc = { version = "1.0", features = ["parallel"] }