feat: Add support for detecting AWS as a cloud provider when IMDSv2 is in use #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also just realized I didn't implement this for getting AWS credentials from IMDSv2, only the detection, ill take a look at adding that too |
|
This is wonderful - thank you, Riley! Merging and adding you to credits too! Looking forward to anything you can do on fetching credentials. |
|
Can I put a Twitter handle in the credits file for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for AWS IMDSv2.
I am not in love with the abstraction and would be willing to alter based on suggestions. I had to change the implementation of GetRequests to return the statusCode, as with IMDSv2, the successful response body ends up being the token used for interacting with IMDSv2, so it felt hacky to rely on just trying to verify it via the body with something like a regex.
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instance-metadata-v2-how-it-works.html