Remove offset argument of onScroll prop from WindowVirtualizer

src/react/Virtualizer.tsx

@@ -156,9 +156,8 @@
   scrollRef?: RefObject<HTMLElement | null>;
   /**
    * Callback invoked whenever scroll offset changes.
-   * @param offset Current scrollTop, or scrollLeft if horizontal: true.
    */
-  onScroll?: (offset: number) => void;
+  onScroll?: () => void;
   /**
    * Callback invoked when scrolling stops.
    */
@@ -268,7 +267,8 @@
         }
       );
       const unsubscribeOnScroll = store.$subscribe(UPDATE_SCROLL_EVENT, () => {
-        onScroll[refKey] && onScroll[refKey](store.$getScrollOffset());
+        // https://github.com/inokawa/virtua/discussions/580
+        onScroll[refKey] && onScroll[refKey]();
       });
       const unsubscribeOnScrollEnd = store.$subscribe(
         UPDATE_SCROLL_END_EVENT,
@@ -322,7 +322,7 @@
         scrollTo: scroller.$scrollTo,
         scrollBy: scroller.$scrollBy,
       };
     }, []);
 
     for (let i = startIndex, j = endIndex; i <= j; i++) {
       items.push(getListItem(i));

src/react/WindowVirtualizer.tsx

@@ -107,9 +107,8 @@
   item?: keyof JSX.IntrinsicElements | CustomItemComponent;
   /**
    * Callback invoked whenever scroll offset changes.
-   * @param offset Current scrollTop, or scrollLeft if horizontal: true.
    */
-  onScroll?: (offset: number) => void;
+  onScroll?: () => void;
   /**
    * Callback invoked when scrolling stops.
    */
@@ -198,7 +197,8 @@
         }
       );
       const unsubscribeOnScroll = store.$subscribe(UPDATE_SCROLL_EVENT, () => {
-        onScroll[refKey] && onScroll[refKey](store.$getScrollOffset());
+        // https://github.com/inokawa/virtua/discussions/580
+        onScroll[refKey] && onScroll[refKey]();
       });
       const unsubscribeOnScrollEnd = store.$subscribe(
         UPDATE_SCROLL_END_EVENT,
@@ -232,7 +232,7 @@
         findEndIndex: store.$findEndIndex,
         scrollToIndex: scroller.$scrollToIndex,
       };
     }, []);
 
     for (let i = startIndex, j = endIndex; i <= j; i++) {
       const e = getElement(i);

src/solid/WindowVirtualizer.tsx

@@ -84,9 +84,8 @@ export interface WindowVirtualizerProps<T> {
   horizontal?: boolean;
   /**
    * Callback invoked whenever scroll offset changes.
-   * @param offset Current scrollTop, or scrollLeft if horizontal: true.
    */
-  onScroll?: (offset: number) => void;
+  onScroll?: () => void;
   /**
    * Callback invoked when scrolling stops.
    */
@@ -130,7 +129,8 @@ export const WindowVirtualizer = <T,>(
   });
 
   const unsubscribeOnScroll = store.$subscribe(UPDATE_SCROLL_EVENT, () => {
-    props.onScroll?.(store.$getScrollOffset());
+    // https://github.com/inokawa/virtua/discussions/580
+    props.onScroll?.();
   });
   const unsubscribeOnScrollEnd = store.$subscribe(
     UPDATE_SCROLL_END_EVENT,

src/svelte/WindowVirtualizer.svelte

@@ -47,7 +47,8 @@
   });
 
   const unsubscribeOnScroll = store.$subscribe(UPDATE_SCROLL_EVENT, () => {
-    onscroll && onscroll(store.$getScrollOffset());
+    // https://github.com/inokawa/virtua/discussions/580
+    onscroll && onscroll();
   });
   const unsubscribeOnScrollEnd = store.$subscribe(
     UPDATE_SCROLL_END_EVENT,

src/svelte/WindowVirtualizer.type.ts

@@ -40,9 +40,8 @@ export interface WindowVirtualizerProps<T> {
   horizontal?: boolean;
   /**
    * Callback invoked whenever scroll offset changes.
-   * @param offset Current scrollTop, or scrollLeft if horizontal: true.
    */
-  onscroll?: (offset: number) => void;
+  onscroll?: () => void;
   /**
    * Callback invoked when scrolling stops.
    */

src/vue/VList.tsx

@@ -49,8 +49,8 @@ export const VList = /*#__PURE__*/ defineComponent({
   setup(props, { emit, expose, slots }) {
     const horizontal = props.horizontal;
 
-    const onScroll = (offset: number) => {
-      emit("scroll", offset);
+    const onScroll = () => {
+      emit("scroll");
     };
     const onScrollEnd = () => {
       emit("scrollEnd");
@@ -116,9 +116,8 @@ export const VList = /*#__PURE__*/ defineComponent({
   {
     /**
      * Callback invoked whenever scroll offset changes.
-     * @param offset Current scrollTop, or scrollLeft if horizontal: true.
      */
-    scroll: (offset: number) => void;
+    scroll: () => void;
     /**
      * Callback invoked when scrolling stops.
      */

src/vue/Virtualizer.tsx

@@ -154,7 +154,8 @@ export const Virtualizer = /*#__PURE__*/ defineComponent({
     });
 
     const unsubscribeOnScroll = store.$subscribe(UPDATE_SCROLL_EVENT, () => {
-      emit("scroll", store.$getScrollOffset());
+      // https://github.com/inokawa/virtua/discussions/580
+      emit("scroll");
     });
     const unsubscribeOnScrollEnd = store.$subscribe(
       UPDATE_SCROLL_END_EVENT,
@@ -295,9 +296,8 @@ export const Virtualizer = /*#__PURE__*/ defineComponent({
   {
     /**
      * Callback invoked whenever scroll offset changes.
-     * @param offset Current scrollTop, or scrollLeft if horizontal: true.
      */
-    scroll: (offset: number) => void;
+    scroll: () => void;
     /**
      * Callback invoked when scrolling stops.
      */