Lint changelogs in CI

Author: neilmayhew

.github/workflows/haskell.yml

@@ -52,3 +52,8 @@ jobs:
 
     - name: Run tests
       run: cabal test all
+
+    - name: Lint changelogs
+      run: |
+        cabal run -- cardano-ledger-release-tool changelogs -i $(git ls-files '*CHANGELOG.md')
+        git diff --exit-code

changelogs/Changelogs.hs

@@ -5,9 +5,9 @@
 module Changelogs (name, subcmd, version) where
 
 import Changelog
-import Control.Monad (unless)
-import Data.Either (lefts)
-import Data.Foldable (for_)
+import Control.Monad (when, (<=<))
+import Data.Bitraversable (bitraverse)
+import Data.Either (isLeft)
 import Data.Functor ((<&>))
 import Data.Text.Lazy (Text, unpack)
 import Data.Traversable (for)
@@ -68,12 +68,10 @@ subcmd :: Mod CommandFields (Global.Options -> IO ())
 subcmd =
   command "changelogs" $
     options <&> \Options {..} Global.Options {} -> do
-      errs <- fmap lefts . for optChangelogs $ \fp -> do
-        tryAny $ do
+      failure <- fmap (any isLeft) . for optChangelogs $ \fp -> do
+        bitraverse (hPrint stderr) pure <=< tryAny $ do
           let
             throwError e = errorWithoutStackTrace $ fp <> ": " <> TL.unpack e
             writeLog = optWriteFile fp . renderChangelog optBulletHierarchy
           either throwError writeLog . parseChangelog =<< TL.readFile fp
-      for_ errs $
-        hPrint stderr
-      unless (null errs) exitFailure
+      when failure exitFailure