From 4ce5b29f464e7e59da3ad387250b61e91f5df666 Mon Sep 17 00:00:00 2001 From: kukkok3 <93382903+kukkok3@users.noreply.github.com> Date: Thu, 8 Aug 2024 13:11:29 +0200 Subject: [PATCH 1/2] fix: flutter integration tests --- catalyst_voices/test_driver/Earthfile | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/catalyst_voices/test_driver/Earthfile b/catalyst_voices/test_driver/Earthfile index 6cea7c8fa60..61f6656df5f 100644 --- a/catalyst_voices/test_driver/Earthfile +++ b/catalyst_voices/test_driver/Earthfile @@ -2,8 +2,7 @@ VERSION 0.8 IMPORT ../ AS catalyst-voices -# TODO(kukko3) - fix and enable -disabled-integration-test-web: +integration-test-web: FROM catalyst-voices+build-web ARG TARGETARCH ARG browser @@ -38,8 +37,7 @@ disabled-integration-test-web: exit 1 END -# TODO(kukko3) - fix and enable -disabled-test-web-all: - BUILD +disabled-integration-test-web \ +test-web-all: + BUILD +integration-test-web \ --browser=chrome \ --browser=firefox From b9d45a6eee1a8c14d0ad1dfc7a468fc920265e61 Mon Sep 17 00:00:00 2001 From: kukkok3 <93382903+kukkok3@users.noreply.github.com> Date: Thu, 8 Aug 2024 13:12:46 +0200 Subject: [PATCH 2/2] fix: remove secret check --- catalyst_voices/Earthfile | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/catalyst_voices/Earthfile b/catalyst_voices/Earthfile index 8117ddd554f..4270891a17c 100644 --- a/catalyst_voices/Earthfile +++ b/catalyst_voices/Earthfile @@ -68,16 +68,11 @@ test-unit: # Build web version of Catalyst Voices build-web: FROM +builder - ARG SECRETS_ARE_AVAILABLE=false ARG SENTRY_DSN - IF [$SECRETS_ARE_AVAILABLE] - ARG WORKDIR=/frontend/catalyst_voices - DO flutter-ci+BUILD_WEB --TARGET=lib/configs/main_web.dart --dart-define SENTRY_DSN=$SENTRY_DSN --WORKDIR=$WORKDIR - SAVE ARTIFACT web - ELSE - RUN echo "No secrets are available in Earthly yet." - END + ARG WORKDIR=/frontend/catalyst_voices + DO flutter-ci+BUILD_WEB --TARGET=lib/configs/main_web.dart --dart-define SENTRY_DSN=$SENTRY_DSN --WORKDIR=$WORKDIR + SAVE ARTIFACT web package: FROM nginx:alpine3.18