Noise generator file #55
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maedoc
reviewed
Jan 24, 2024
vbjax/noise_generator.py
Outdated
| import matplotlib.pyplot as plt | ||
| import jax | ||
|
|
||
| def noise_psd(shape, key, sigma=1, psd = lambda f: 1, **kwargs): |
There was a problem hiding this comment.
a bit like other APIs, could we do something like
psdgen = make_noise_psd(psd=lambda f: 1)?
maedoc
reviewed
Jan 24, 2024
vbjax/noise_generator.py
Outdated
|
|
||
| """ | ||
|
|
||
| X_white = np.fft.rfft(jax.random.normal(key, shape)*sigma) |
There was a problem hiding this comment.
you can use a nested function here
def make_gen(..., psd):
def gen(key, shape):
X_white = ...
S = psd(...)
return ...
return gen
rainbow_gen = make_noise_gen(psd=lambda f: rainbow( f ) )
|
make issue is that you need to close over (i.e. use nested function which doesn't take the psd as an argument) in order for this to work well with the jit. the decorator works in this case.. but it's simpler to use the nested function and it's a pattern used elsewhere because it extends nicely to cases where you need the nested function to close & JIT over specific static arrays and functions. |
|
I'll try to rewrite, thank you for your comments!
Le mer. 24 janv. 2024, 14:08, marmaduke woodman ***@***.***>
a écrit :
… make issue is that you need to close over (i.e. use nested function which
doesn't take the psd as an argument) in order for this to work well with
the jit.
the decorator works in this case.. but it's simpler to use the nested
function and it's a pattern used elsewhere because it extends nicely to
cases where you need the nested function to close & JIT over specific
static arrays and functions.
—
Reply to this email directly, view it on GitHub
<#55 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZ3GWO5UOFEU6N2X5NHDOLYQEBU3AVCNFSM6AAAAABCITMCMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBYGA4TAMZUG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
bump |
maedoc
reviewed
Mar 19, 2024
| @@ -13,9 +13,9 @@ def heun_step(x, dfun, dt, *args, add=0, adhoc=None): | |||
| """ | |||
| adhoc = adhoc or (lambda x,*args: x) | |||
| d1 = dfun(x, *args) | |||
| xi = adhoc(x + dt*d1 + add, *args) | |||
| xi = adhoc(x, dt*d1 + add, *args) | |||
There was a problem hiding this comment.
what's going on here? the adhoc function should have access to the value of xi = x + dt*d1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
module to group noise related components.
Allows to generate different colors of noise of desired shape.