Run tests in Node 8 and prevent creation of a package-lock.json with …

…npm 5 Closes #398
insin · Nov 3, 2017 · cff7caf · cff7caf
1 parent a313ba5
commit cff7caf
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 1 deletion.
diff --git a/.npmrc b/.npmrc
@@ -1 +1,2 @@
 save=false
+package-lock=false
diff --git a/.travis.yml b/.travis.yml
@@ -4,6 +4,7 @@ language: node_js
 node_js:
   - 4
   - 6
+  - 8
 
 cache:
   directories:

diff --git a/CHANGES.md b/CHANGES.md
@@ -5,6 +5,7 @@
 
 ## Changed
 
+- nwb is now also tested against Node 8 now that it's the Long Term Support version.
 - Reverted the Webpack settings change for `webpack.compat.enzyme` config in v0.19.0, as it only applied while the version numbers of published React packages were out of sync. The compatibility settings assume Enzyme v2 and React >= v15.5.
 - `style-loader`'s new `hmr` option is set to `false` when creating builds to prevent inclusion of its HMR code.
 

diff --git a/src/utils.js b/src/utils.js
@@ -162,7 +162,7 @@ export function install(
     return process.nextTick(cb)
   }
 
-  let npmArgs = ['install', '--silent', '--no-progress']
+  let npmArgs = ['install', '--silent', '--no-progress', '--no-package-lock']
 
   if (save) {
     npmArgs.push(`--save${dev ? '-dev' : ''}`)
-Original file line number
+Diff line change
@@ Expand Up / @@ -4,6 +4,7 @@ language: node_js @@
     node_js:
       - 4
       - 6
+      - 8
     cache:
       directories:
@@ Expand Down @@