From f84b8d46164b51438cd0660f213c5634ec952ef7 Mon Sep 17 00:00:00 2001 From: Arya Mohanan Date: Thu, 4 Apr 2024 21:17:41 +0530 Subject: [PATCH] docs: updated the comments --- packages/aws-fargate/esm-loader.mjs | 12 ++++++------ packages/azure-container-services/esm-loader.mjs | 9 ++++----- packages/collector/esm-loader.mjs | 9 ++++----- packages/google-cloud-run/esm-loader.mjs | 10 +++++----- 4 files changed, 19 insertions(+), 21 deletions(-) diff --git a/packages/aws-fargate/esm-loader.mjs b/packages/aws-fargate/esm-loader.mjs index e51780cb2..e94816723 100644 --- a/packages/aws-fargate/esm-loader.mjs +++ b/packages/aws-fargate/esm-loader.mjs @@ -6,20 +6,20 @@ /** * IMPORTANT NOTE: From Node.js version 18.19 and above, the ESM loaders operate off-thread. - * Consequently, ESM instrumentation using '--experimental-loader' becomes obsolete. - * Instead, we recommend using '--import' for loading instrumentation and relocating the - * Instana collector loading to './register' file. + * Consequently, ESM instrumentation using '--experimental-loader' becomes deprecated. + * Instead, we are using '--import' for loading instrumentation and relocated the Instana collector + * loading to './register' file. * Please note that '--import' flag is unavailable in earlier versions, hence we maintain both setups. - * We will incorporate the native ESM support by using 'import-in-the-middle'. + * We will incorporate the native ESM support by using 'import-in-the-middle' ith register method. * * Usage: * ENV NODE_OPTIONS='--experimental-loader=/instana/node_modules/ * @instana/aws-fargate/esm-loader.mjs' * * NOTE: When using ESM, the customers have the option to set up the aws-fargate - * by configuring ENV variable within the docker file. Given that aws-fargate + * by configuring ENV variable within the docker file. Given that aws-fargate * self-initializes, its current utilization remains unchanged. - * However, there's potential for future integration where the init() method + * However, there's potential for future integration where the init() method * can be invoked from this context. */ diff --git a/packages/azure-container-services/esm-loader.mjs b/packages/azure-container-services/esm-loader.mjs index 250c5b578..9dbd9c7e0 100644 --- a/packages/azure-container-services/esm-loader.mjs +++ b/packages/azure-container-services/esm-loader.mjs @@ -6,11 +6,11 @@ /** * IMPORTANT NOTE: From Node.js version 18.19 and above, the ESM loaders operate off-thread. - * Consequently, ESM instrumentation using '--experimental-loader' becomes obsolete. - * Instead, we recommend using '--import' for loading instrumentation and relocating the - * Instana collector loading to './register' file. + * Consequently, ESM instrumentation using '--experimental-loader' becomes deprecated. + * Instead, we are using '--import' for loading instrumentation and relocated the Instana collector + * loading to './register' file. * Please note that '--import' flag is unavailable in earlier versions, hence we maintain both setups. - * We will incorporate the native ESM support by using 'import-in-the-middle'. + * We will incorporate the native ESM support by using 'import-in-the-middle' ith register method. * * Usage: * ENV NODE_OPTIONS='--experimental-loader=/instana/node_modules/ @@ -24,4 +24,3 @@ */ import './src/index.js'; - diff --git a/packages/collector/esm-loader.mjs b/packages/collector/esm-loader.mjs index de54fa9fc..cf561464a 100644 --- a/packages/collector/esm-loader.mjs +++ b/packages/collector/esm-loader.mjs @@ -6,12 +6,11 @@ /** * IMPORTANT NOTE: From Node.js version 18.19 and above, the ESM loaders operate off-thread. - * Consequently, ESM instrumentation using '--experimental-loader' becomes obsolete. - * Instead, we recommend using '--import' for loading instrumentation and relocating the - * Instana collector loading to './register' file. + * Consequently, ESM instrumentation using '--experimental-loader' becomes deprecated. + * Instead, we are using '--import' for loading instrumentation and relocated the Instana collector + * loading to './register' file. * Please note that '--import' flag is unavailable in earlier versions, hence we maintain both setups. - * We will incorporate the native ESM support by using 'import-in-the-middle'. - * + * We will incorporate the native ESM support by using 'import-in-the-middle' ith register method. * Usage: * node --experimental-loader=@instana/collector/esm-loader.mjs server.js * diff --git a/packages/google-cloud-run/esm-loader.mjs b/packages/google-cloud-run/esm-loader.mjs index f6b5730e8..f86f8fe49 100644 --- a/packages/google-cloud-run/esm-loader.mjs +++ b/packages/google-cloud-run/esm-loader.mjs @@ -6,11 +6,11 @@ /** * IMPORTANT NOTE: From Node.js version 18.19 and above, the ESM loaders operate off-thread. - * Consequently, ESM instrumentation using '--experimental-loader' becomes obsolete. - * Instead, we recommend using '--import' for loading instrumentation and relocating the - * Instana collector loading to './register' file. + * Consequently, ESM instrumentation using '--experimental-loader' becomes deprecated. + * Instead, we are using '--import' for loading instrumentation and relocated the Instana collector + * loading to './register' file. * Please note that '--import' flag is unavailable in earlier versions, hence we maintain both setups. - * We will incorporate the native ESM support by using 'import-in-the-middle'. + * We will incorporate the native ESM support by using 'import-in-the-middle' ith register method. * * Usage: * ENV NODE_OPTIONS='--experimental-loader=/instana/node_modules/ @@ -23,4 +23,4 @@ * can be invoked from this context. */ -import './src/index.js'; \ No newline at end of file +import './src/index.js';