Add dbname as collecting parameter for PEP0249
#461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ferenc-
requested changes
Oct 18, 2023
Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
Guarantees that PEP0249 can test all options for database parameter name during the connection. Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
pvital
force-pushed
the
dbname_param_support
branch
from
221432e to
3dbfd5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two commits.
The first one, 55e826e, adds
dbnameas a collecting parameter for PEP0249. When connecting to a PostgreSQL server, for example, using the psycopg2 module, the parameterdbnamecan be used to specify the database name to connect into, like the following piece of code:Without this fix, the Instana UI is not able to display the database name when inspecting an EXIT span, as shown in the following image:
With this fix, the name of the database is collected and displayed:
The second commit, 221432e, adapts all the unit tests that use PEP0249 to guarantee that all options for database parameter names during the connection are tested.