Allows MMLU to have the system_prompt provided to it #197
+47
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
CI/CD
Signed-off-by: Oleg S <97077423+RobotSail@users.noreply.github.com>
6 tasks
|
I am currently running a e2e test on granite-8b-starter and still seeing failures (manually brought in patches) |
Confirmed my image had patches for both libraries and then proceeded to run mmlu eval |
danmcp
reviewed
Dec 12, 2024
There was a problem hiding this comment.
Changes look good, might be good to pass an example system_prompt from a unit test:
Line 65 in d8d6097
It wouldn't test much but at least to make sure the arg passing works.
The other place to potentially add an example would be in the test scripts:
That's less valuable since they aren't run anywhere. But could be a helpful example.
|
Hit with this same error |
|
I am happy to bring in patches and do a e2e test to ensure we are at a place that everything is good on granite-8b-starter |
Signed-off-by: Oleg S <97077423+RobotSail@users.noreply.github.com>
RobotSail
commented
Dec 13, 2024
There was a problem hiding this comment.
Changes look good, might be good to pass an example system_prompt from a unit test:
Line 65 in d8d6097
I've updated the PR to include these changes, please take a look and let me know if there's anything I missed.
Regarding this comment, Tyler and I had a debug session where we found that adding the new prompt template causes MMLU to exceed the existing model's context (4096 tokens) when --few-shot=5 is used. This happens because lm_eval harness appears to truncate the prompt by default and just send the last 4096 tokens fitting into the context, which causes the system prompt to disappear and throw an error on certain models.
The resolution here is to use a lower number for --few-shot such as 1-3.
danmcp
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MMLU evaluator currently performs MMLU evaluation by calling out to the lm_eval harness. The lm-eval harness itself handles the evaluation by creating its own prompt clientside and then passing it to
/v1/completionsof whatever OpenAI-compatible API that it's expecting to receive it at the other end.Certain models however require to have their chat template used to be used during inference in order to get the best results. This PR adjusts the MMLU evaluator by allowing the system prompt to be provided to the model and then will enable the chat template mode to be used when it's present.
Signed-off-by: Oleg S 97077423+RobotSail@users.noreply.github.com