-
Notifications
You must be signed in to change notification settings - Fork 903
chore: Refactor integration tests #2941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
192aa6b to
e5d0594
Compare
nickfloyd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are fantastic! There was a lot, thank you for putting in the 💪 here! I think the only thing that stood out to me is that the workflows / ci jobs need to be updated now that you've change the environment vars - I saw that you updated the contributing doc.
|
Thanks @nickfloyd I had meant to add that to the description as work to do, as I removed the actual automation changes for a later PR. I also need to do a clean review (not straight after making the changes) to check that nothing got screwed up in the merge. |
e5d0594 to
5cfd201
Compare
|
@nickfloyd this PR depends on #2946 to be able to configure the automation tests. |
f006fd7 to
bc1fc79
Compare
bc1fc79 to
fe15320
Compare
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
fe15320 to
fc0fc6f
Compare
|
@nickfloyd I think these are ready for a final review. They're in better shape than the ones currently on |
This PR replaces #2476.
Before the change?
After the change?
Outstanding
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!