Added allowsDeletionsand allowsForcePushessettings

[frbayart]

In the latest Github GraphQL schema https://developer.github.com/v4/changelog/2020-11-13-schema-changes/ we can manage the rules applied to everyone including administrators.

I have updated https://github.com/shurcooL/githubv4 to add allowsDeletionsand allowsForcePushessettings.

And now I would like to suggest adding it to the related Terraform provider.

[frbayart]

@jcudit What can I do about "failing checks"?

[jcudit]

@frbayart please ignore the failed acceptance tests. There are issues with running them from forks.

The TravisCI failure is relevant though:

ERRO Running error: inspect: analysis skipped: errors in package: [/home/travis/gopath/src/github.com/terraform-providers/terraform-provider-github/main.go:5:2: could not import github.com/terraform-providers/terraform-provider-github/github (/home/travis/gopath/src/github.com/terraform-providers/terraform-provider-github/github/resource_github_branch_protection.go:250:3: unknown field AllowsDeletions in struct literal)]

I think its complaining because the latest changes to shurcooL/githubv4 are not vendored in. Please run go mod vendor and check in the vendor/ directory.

Feel free to cherry-pick this commit as well to get a test included.

[frbayart]

go mod vendor is correct now, I can see AllowsDeletions.

I have included the test (now I know what I should do for the next time).

I have aligned my branch with master I hope it was not an error, else I will recreate a new PR let me know.

[neel-mookerjee]

Did it get added to the Github provider yet? I have:
Terraform v0.14.4 \+ provider registry.terraform.io/integrations/github v4.3.0

Getting:
Error: Field 'allowsDeletions' doesn't exist on type 'BranchProtectionRule'

PS: I am trying to import a branch_protection state

[frbayart]

I use it on

      source  = "integrations/github"
      version = "4.2.0"

and my usage is:

resource "github_branch_protection" "branch" {
  provider = kensu-github

  for_each = var.branches

  pattern                = each.value["pattern"]
  repository_id          = github_repository.repository.node_id
  enforce_admins         = true
  allows_deletions       = each.value["allows_deletions"]
  allows_force_pushes    = false
  require_signed_commits = true