From 9a035b5778fb03bbe1eb9e95e18d5d12685ec3e3 Mon Sep 17 00:00:00 2001 From: Alex Baden Date: Fri, 12 Jan 2024 09:10:36 -0700 Subject: [PATCH 1/3] Enable test_locality on XPU GENX fix is required to replace the unsupported opencl function call --- python/test/unit/language/test_core.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/python/test/unit/language/test_core.py b/python/test/unit/language/test_core.py index 86a2671d1f..0f6845b6b3 100644 --- a/python/test/unit/language/test_core.py +++ b/python/test/unit/language/test_core.py @@ -1884,9 +1884,6 @@ def histogram_kernel(x_ptr, z_ptr, M: tl.constexpr, N: tl.constexpr): @pytest.mark.parametrize("N", [512, 1024, 2048]) @pytest.mark.parametrize("num_pid_n", [2, 4]) def test_locality(op, BLOCK_N, N, num_pid_n, device): - if is_xpu(device): - pytest.skip("FIXME: Does run correctly on XPU") - @triton.jit def kernel(X, Y, N, BLOCK_M: tl.constexpr, BLOCK_N: tl.constexpr): start_m = tl.program_id(0) From c80e3860650b588971be542a2f939e77238b6581 Mon Sep 17 00:00:00 2001 From: Alex Baden Date: Wed, 17 Jan 2024 14:06:40 -0700 Subject: [PATCH 2/3] fix format --- python/test/unit/language/test_core.py | 1 + 1 file changed, 1 insertion(+) diff --git a/python/test/unit/language/test_core.py b/python/test/unit/language/test_core.py index 0f6845b6b3..633131a6cd 100644 --- a/python/test/unit/language/test_core.py +++ b/python/test/unit/language/test_core.py @@ -1884,6 +1884,7 @@ def histogram_kernel(x_ptr, z_ptr, M: tl.constexpr, N: tl.constexpr): @pytest.mark.parametrize("N", [512, 1024, 2048]) @pytest.mark.parametrize("num_pid_n", [2, 4]) def test_locality(op, BLOCK_N, N, num_pid_n, device): + @triton.jit def kernel(X, Y, N, BLOCK_M: tl.constexpr, BLOCK_N: tl.constexpr): start_m = tl.program_id(0) From 36819ccf79b52d86b4424aa3192c5dd3da9d01e9 Mon Sep 17 00:00:00 2001 From: Alex Baden Date: Wed, 17 Jan 2024 14:13:17 -0700 Subject: [PATCH 3/3] more format --- python/test/unit/language/test_core.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/test/unit/language/test_core.py b/python/test/unit/language/test_core.py index 633131a6cd..33dc1f039f 100644 --- a/python/test/unit/language/test_core.py +++ b/python/test/unit/language/test_core.py @@ -1884,7 +1884,7 @@ def histogram_kernel(x_ptr, z_ptr, M: tl.constexpr, N: tl.constexpr): @pytest.mark.parametrize("N", [512, 1024, 2048]) @pytest.mark.parametrize("num_pid_n", [2, 4]) def test_locality(op, BLOCK_N, N, num_pid_n, device): - + @triton.jit def kernel(X, Y, N, BLOCK_M: tl.constexpr, BLOCK_N: tl.constexpr): start_m = tl.program_id(0)