From c071d360b883c3cda99e26106280f2cd0e9863ca Mon Sep 17 00:00:00 2001 From: "Plyakhin, Yury" Date: Wed, 15 Mar 2023 23:16:11 +0000 Subject: [PATCH 1/3] [SYCL][Matrix] Remove xfail from tests that passes now --- SYCL/Matrix/XMX8/element_wise_all_ops_int8_packed.cpp | 5 ----- 1 file changed, 5 deletions(-) diff --git a/SYCL/Matrix/XMX8/element_wise_all_ops_int8_packed.cpp b/SYCL/Matrix/XMX8/element_wise_all_ops_int8_packed.cpp index 7124332923..53a4770348 100644 --- a/SYCL/Matrix/XMX8/element_wise_all_ops_int8_packed.cpp +++ b/SYCL/Matrix/XMX8/element_wise_all_ops_int8_packed.cpp @@ -12,11 +12,6 @@ // RUN: %GPU_RUN_PLACEHOLDER %t.out // This test stores the matrix B that is VNNIed (packed) in a row major fashion. -// This is expected to fail on the GPU because the implementation does not -// support automatic transformation YET, in this case: VNNI to row major in the -// store. - -// XFAIL: gpu #include #include From e37a71f42c67090c7e923f9d375f7c02e7c63b26 Mon Sep 17 00:00:00 2001 From: Yury Plyakhin Date: Thu, 16 Mar 2023 13:41:23 -0700 Subject: [PATCH 2/3] Just a clean up for a few tests --- SYCL/Matrix/XMX8/element_wise_all_ops_int8_packed.cpp | 2 +- SYCL/Matrix/element_wise_all_ops_int8_packed.cpp | 6 ++---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/SYCL/Matrix/XMX8/element_wise_all_ops_int8_packed.cpp b/SYCL/Matrix/XMX8/element_wise_all_ops_int8_packed.cpp index 53a4770348..696dfbf364 100644 --- a/SYCL/Matrix/XMX8/element_wise_all_ops_int8_packed.cpp +++ b/SYCL/Matrix/XMX8/element_wise_all_ops_int8_packed.cpp @@ -11,7 +11,7 @@ // RUN: %CPU_RUN_PLACEHOLDER %t.out // RUN: %GPU_RUN_PLACEHOLDER %t.out -// This test stores the matrix B that is VNNIed (packed) in a row major fashion. +// This test stores the matrix B that is VNNIed (packed). #include #include diff --git a/SYCL/Matrix/element_wise_all_ops_int8_packed.cpp b/SYCL/Matrix/element_wise_all_ops_int8_packed.cpp index 6008079449..e7a0664688 100644 --- a/SYCL/Matrix/element_wise_all_ops_int8_packed.cpp +++ b/SYCL/Matrix/element_wise_all_ops_int8_packed.cpp @@ -11,10 +11,8 @@ // RUN: %CPU_RUN_PLACEHOLDER %t.out // RUN: %GPU_RUN_PLACEHOLDER %t.out -// This test stores the matrix B that is VNNIed (packed) in a row major fashion. -// This is expected to fail on the GPU because the implementation does not -// support automatic transformation YET, in this case: VNNI to row major in the -// store. +// This test stores the matrix B that is VNNIed (packed). +// This is expected to fail on the GPU because some built-ins are missing still. // XFAIL: gpu From 63b8c6a510b343d05f0f305fd1dbb9b9afe30379 Mon Sep 17 00:00:00 2001 From: Yury Plyakhin Date: Thu, 16 Mar 2023 13:49:23 -0700 Subject: [PATCH 3/3] [SYCL][Matrix] Added gpu param to tests which should run only on gpu --- SYCL/Matrix/Legacy/element_wise_all_ops_half.cpp | 2 +- SYCL/Matrix/Legacy/joint_matrix_half.cpp | 2 +- SYCL/Matrix/element_wise_all_ops_half.cpp | 2 +- SYCL/Matrix/joint_matrix_half.cpp | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/SYCL/Matrix/Legacy/element_wise_all_ops_half.cpp b/SYCL/Matrix/Legacy/element_wise_all_ops_half.cpp index bd8becff4c..2cb93a42a8 100644 --- a/SYCL/Matrix/Legacy/element_wise_all_ops_half.cpp +++ b/SYCL/Matrix/Legacy/element_wise_all_ops_half.cpp @@ -5,7 +5,7 @@ // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // //===----------------------------------------------------------------------===// -// REQUIRES: matrix +// REQUIRES: matrix,gpu // Only runs on DPAS because AMX implementation does not support half data type // yet diff --git a/SYCL/Matrix/Legacy/joint_matrix_half.cpp b/SYCL/Matrix/Legacy/joint_matrix_half.cpp index d88a9f0b1b..d9a1c19e18 100644 --- a/SYCL/Matrix/Legacy/joint_matrix_half.cpp +++ b/SYCL/Matrix/Legacy/joint_matrix_half.cpp @@ -5,7 +5,7 @@ // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // //===----------------------------------------------------------------------===// -// REQUIRES: matrix +// REQUIRES: matrix,gpu // RUN: %clangxx -fsycl %s -o %t.out -DSYCL_EXT_ONEAPI_MATRIX_VERSION=1 // Only run on the GPU because half is not supported on AMX hardware diff --git a/SYCL/Matrix/element_wise_all_ops_half.cpp b/SYCL/Matrix/element_wise_all_ops_half.cpp index e860180c03..e4b7c95a2b 100644 --- a/SYCL/Matrix/element_wise_all_ops_half.cpp +++ b/SYCL/Matrix/element_wise_all_ops_half.cpp @@ -5,7 +5,7 @@ // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // //===----------------------------------------------------------------------===// -// REQUIRES: matrix +// REQUIRES: matrix,gpu // Only runs on DPAS because AMX implementation does not support half data type // yet diff --git a/SYCL/Matrix/joint_matrix_half.cpp b/SYCL/Matrix/joint_matrix_half.cpp index 1d131a64a8..be0bf1487c 100644 --- a/SYCL/Matrix/joint_matrix_half.cpp +++ b/SYCL/Matrix/joint_matrix_half.cpp @@ -5,7 +5,7 @@ // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // //===----------------------------------------------------------------------===// -// REQUIRES: matrix +// REQUIRES: matrix,gpu // RUN: %clangxx -fsycl %s -o %t.out -DSYCL_EXT_ONEAPI_MATRIX_VERSION=4 // Only run on the GPU because half is not supported on AMX hardware