From 96a201b684e2b7a631ce14baca379a6ace4f4c45 Mon Sep 17 00:00:00 2001 From: Andrei Elovikov Date: Tue, 10 Jun 2025 07:19:41 -0700 Subject: [PATCH 1/2] [SYCL][E2E][LIT] Fix processing of boolean parameters They're read as strings, not booleans. Need to be processed as such. --- sycl/test-e2e/lit.cfg.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sycl/test-e2e/lit.cfg.py b/sycl/test-e2e/lit.cfg.py index 240ebe0f268e7..3e3182887174b 100644 --- a/sycl/test-e2e/lit.cfg.py +++ b/sycl/test-e2e/lit.cfg.py @@ -382,7 +382,7 @@ def open_check_file(file_name): else: config.substitutions.append(("%level_zero_options", "")) -if lit_config.params.get("test-preview-mode", False): +if lit_config.params.get("test-preview-mode", 'False') != 'False': config.available_features.add("preview-mode") else: # Check for sycl-preview library @@ -1086,7 +1086,7 @@ def get_sycl_ls_verbose(sycl_device, env): else: config.intel_driver_ver[full_name] = {} -if lit_config.params.get("compatibility_testing", False): +if lit_config.params.get("compatibility_testing", 'False') != 'False': config.substitutions.append(("%clangxx", " true ")) config.substitutions.append(("%clang", " true ")) else: From 17ba8cc9cd0a7e831aeb8eda73efe630623ef587 Mon Sep 17 00:00:00 2001 From: aelovikov-intel Date: Tue, 10 Jun 2025 08:05:43 -0700 Subject: [PATCH 2/2] Apply suggestions from code review --- sycl/test-e2e/lit.cfg.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sycl/test-e2e/lit.cfg.py b/sycl/test-e2e/lit.cfg.py index 3e3182887174b..e2226f2ae063a 100644 --- a/sycl/test-e2e/lit.cfg.py +++ b/sycl/test-e2e/lit.cfg.py @@ -382,7 +382,7 @@ def open_check_file(file_name): else: config.substitutions.append(("%level_zero_options", "")) -if lit_config.params.get("test-preview-mode", 'False') != 'False': +if lit_config.params.get("test-preview-mode", "False") != "False": config.available_features.add("preview-mode") else: # Check for sycl-preview library @@ -1086,7 +1086,7 @@ def get_sycl_ls_verbose(sycl_device, env): else: config.intel_driver_ver[full_name] = {} -if lit_config.params.get("compatibility_testing", 'False') != 'False': +if lit_config.params.get("compatibility_testing", "False") != "False": config.substitutions.append(("%clangxx", " true ")) config.substitutions.append(("%clang", " true ")) else: