Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Driver][SYCL] Add support for -fsycl-force-target #6653

Merged
merged 2 commits into from
Aug 31, 2022

Conversation

mdtoguchi
Copy link
Contributor

Introduce -fsycl-force-target=arg support. This is used along with -fsycl
to allow the user to override the target used to unbundle device objects
from fat objects and archives.

For example, object.o is built from -fsycl-targets=spir64. The user wants
to build with -fsycl-targets=spir64_gen and object.o. Use of
-fsycl-force-target=spir64 allows for this to be accomplished.

Additional notes:

  • Only valid when used with a single triple from -fsycl-targets
  • Applies to all unbundled archives and objects

Introduce -fsycl-force-target=arg support.  This is used along with -fsycl
to allow the user to override the target used to unbundle device objects
from fat objects and archives.

For example, object.o is built from -fsycl-targets=spir64.  The user wants
to build with -fsycl-targets=spir64_gen and object.o.  Use of
-fsycl-force-target=spir64 allows for this to be accomplished.

Additional notes:
  - Only valid when used with a single triple from -fsycl-targets
  - Applies to all unbundled archives and objects
@mdtoguchi mdtoguchi requested review from a team as code owners August 27, 2022 17:53
premanandrao
premanandrao previously approved these changes Aug 29, 2022
Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect the Driver team to review this more thoroughly, but the FE changes look okay to me.

Copy link
Contributor

@elizabethandrews elizabethandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE changes LGTM

hchilama
hchilama previously approved these changes Aug 29, 2022
@mdtoguchi
Copy link
Contributor Author

@intel/dpcpp-doc-reviewers, can you take a look?

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Reviewing for @intel/dpcpp-doc-reviewers .

@steffenlarsen steffenlarsen merged commit 1d95f2e into intel:sycl Aug 31, 2022
@mdtoguchi mdtoguchi deleted the sycl-force-target branch August 31, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants