Skip to content

Add support for unsupported cert extension. #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 13, 2025
Merged

Add support for unsupported cert extension. #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ad5301
sync spdm-emu
Li-Aaron Sep 22, 2025
e23e072
remove 4.0 deprecated marco
Li-Aaron Sep 22, 2025
cda8fc0
Add support for X509_IGNORE_CRITICAL
Li-Aaron Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spdm-emu
Open in desktop
Submodule spdm-emu updated 185 files
13 changes: 13 additions & 0 deletions teeio-validator/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ SET(CMAKE_BUILD_TYPE ${TARGET} CACHE STRING "Choose the target of build: Debug R
SET(CRYPTO ${CRYPTO} CACHE STRING "Choose the crypto of build: mbedtls openssl" FORCE)
SET(GCOV ${GCOV} CACHE STRING "Choose the target of Gcov: ON OFF, and default is OFF" FORCE)
SET(STACK_USAGE ${STACK_USAGE} CACHE STRING "Choose the target of STACK_USAGE: ON OFF, and default is OFF" FORCE)
set(X509_IGNORE_CRITICAL ${X509_IGNORE_CRITICAL} CACHE STRING "Choose if libspdm-provided cryptography libraries (OpenSSL and MbedTLS) ignore unsupported critical extensions in certificates : ON OFF, and default is OFF" FORCE)

if(NOT GCOV)
SET(GCOV "OFF")
Expand All @@ -24,6 +25,10 @@ if(NOT STACK_USAGE)
SET(STACK_USAGE "OFF")
endif()

if(NOT X509_IGNORE_CRITICAL)
set(X509_IGNORE_CRITICAL "OFF")
endif()

SET(LIBSPDM_DIR ${PROJECT_SOURCE_DIR}/../spdm-emu/libspdm)
SET(SPDM_EMU_DIR ${PROJECT_SOURCE_DIR}/../spdm-emu)
SET(TEEIO_VALIDATOR_DIR ${PROJECT_SOURCE_DIR}/teeio_validator)
Expand Down Expand Up @@ -84,6 +89,14 @@ else()
MESSAGE(FATAL_ERROR "Unkown CRYPTO")
endif()

if (X509_IGNORE_CRITICAL STREQUAL "ON")
if (CRYPTO STREQUAL "openssl")
add_definitions(-DOPENSSL_IGNORE_CRITICAL=1)
elseif(CRYPTO STREQUAL "mbedtls")
add_definitions(-DLIBSPDM_MBEDTLS_X509_ALLOW_UNSUPPORTED_CRITICAL_EXTENSION)
endif()
endif()

if(ENABLE_BINARY_BUILD STREQUAL "1")
if(NOT CRYPTO STREQUAL "openssl")
MESSAGE(FATAL_ERROR "enabling binary build not supported for non-openssl")
Expand Down
2 changes: 1 addition & 1 deletion teeio-validator/library/spdmlib/spdm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ void *spdm_client_init(void)
data16 = 0;
libspdm_set_data(spdm_context, LIBSPDM_DATA_REQ_BASE_ASYM_ALG, &parameter,
&data16, sizeof(data16));
data16 = SPDM_ALGORITHMS_KEY_SCHEDULE_HMAC_HASH;
data16 = SPDM_ALGORITHMS_KEY_SCHEDULE_SPDM;
libspdm_set_data(spdm_context, LIBSPDM_DATA_KEY_SCHEDULE, &parameter, &data16,
sizeof(data16));
data8 = SPDM_ALGORITHMS_OPAQUE_DATA_FORMAT_1;
Expand Down