Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarker: Add a CLI param to set N #162

Open
WilliamTambellini opened this issue Aug 22, 2024 · 1 comment
Open

Benchmarker: Add a CLI param to set N #162

WilliamTambellini opened this issue Aug 22, 2024 · 1 comment

Comments

@WilliamTambellini
Copy link
Contributor

As today the benchmarker benchs 4 cases of partialsort:

   MY_BENCHMARK_CAPTURE(func, type, k10, 10000, 10); \
    MY_BENCHMARK_CAPTURE(func, type, k100, 10000, 100); \
    MY_BENCHMARK_CAPTURE(func, type, k1000, 10000, 1000); \
    MY_BENCHMARK_CAPTURE(func, type, k5000, 10000, 5000);

MY_BENCHMARK_CAPTURE(func, type, k10, 10000, 10); \

For LLM inference the values are more extreme: N (vocab size) = 100000 or more, and k could be even smaller than 10.
Would you mind if I add a CLI arg to set at least N (ARRSIZE) ?

@r-devulap
Copy link
Contributor

I'm not sure if there is way to add command line arguments in google benchmark. You are welcome to add more benchmarks that seem relevant to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants