Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to remove "comments" from configs #134

Open
agember opened this issue Dec 13, 2019 · 4 comments
Open

Add option to remove "comments" from configs #134

agember opened this issue Dec 13, 2019 · 4 comments

Comments

@agember
Copy link

agember commented Dec 13, 2019

It would be useful to include a command-line option that removes "comments" from configs. For example, interface descriptions, BGP neighbor descriptions, remarks in ACLs, etc. Developing keyword lists for this is often non-trivial, so the ability to remove them outright, especially since they don't impact network semantics, would be useful.

(Prompted by a discussion with @sfraint and @progwriter on Slack)

@tandreadi
Copy link

Hi @agember,
I am collaborating with @Elviraant and I am interested in taking over this issue. Contributing to an open-source project is an assignment for "Software Engineering in Practice" offered by the Management Science and Technology department of AUEB. Could you assign me this issue?
Thank you,
Theodora

@agember
Copy link
Author

agember commented Mar 28, 2020

Hi @tandreadi, You'll need to ask @dhalperi to assign this issue to you, since I do not have administrative access to this repository. Also, you may want to look at the modifications in my fork of the repository, which are a first attempt at solving this problem: https://github.com/colgate-cs-research/netconan/tree/aaron-line-anonymization
I am happy to provide additional suggestions/guidance if you're interested; you can also find me (and other folks) on the Batfish Slack workspace: https://join.slack.com/t/batfish-org/shared_invite/enQtMzA0Nzg2OTAzNzQ1LTcyYzY3M2Q0NWUyYTRhYjdlM2IzYzRhZGU1NWFlNGU2MzlhNDY3OTJmMDIyMjQzYmRlNjhkMTRjNWIwNTUwNTQ

@tandreadi
Copy link

@agember thank you very much for all the useful information!

Hi @dhalperi, I am interested in taking over and trying to solve this issue. Could you assign it to me?

@dhalperi
Copy link
Member

dhalperi commented Apr 3, 2020

Hi @tandreadi - you are welcome to work on the issue, no need to assign it to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants