[BREAKING] chore: upgrade to polkadot 0.9.36 #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sander2
changed the title
sander2
force-pushed
the
chore/polkadot-0.9.33
branch
from
2aa3f98 to
d241f34
Compare
sander2
force-pushed
the
chore/polkadot-0.9.33
branch
3 times, most recently
from
c952721 to
c543e81
Compare
sander2
force-pushed
the
chore/polkadot-0.9.33
branch
from
c543e81 to
ba6cd90
Compare
gregdhill
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased on #855 - will rebase after that is merged.
See:
Regarding the
compatibility_mode: this is the PR that added it, in response to this issue. From the issue I infer that you only need a non-default value if you were on a polkadot version older than 0.9.24.Note: due to a change in orml-xtokens (contributed by yours truly😅), this update breaks the xtokens interface. As such, not only will we have to update our code, but all other projects provide xcm bridging UI will have to update their code. So rolling this out is going to be a bit of a challenge..
Please also carefully review the changes to service.rs, I'm not completely confident about the changes