Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement local quoting #2854

Closed
Tracked by #2834
mkurapov opened this issue Aug 9, 2024 · 0 comments · Fixed by #2857
Closed
Tracked by #2834

Implement local quoting #2854

mkurapov opened this issue Aug 9, 2024 · 0 comments · Fixed by #2857
Assignees

Comments

@mkurapov
Copy link
Contributor

mkurapov commented Aug 9, 2024

Context

We will be adding a "local" payment method. The payment handler method service needs to support two methods, getQuote and pay. This issue is about implementing the local quote method in a new "local" payment method handler, which just needs to do the conversion between the sending wallet address and the incoming payment.

Internally, we should be able to differentiate whether a local quote or local payment happened under the hood. Keep in mind, the outgoingPayment.id references (has a FK relationship) to quote.id (the outgoing payment id is actually equal to the quote id)

@github-project-automation github-project-automation bot moved this to Backlog in Rafiki Aug 9, 2024
@mkurapov mkurapov changed the title Implement the local quote method in a new "local" payment method handler, which just needs to do the conversion between the sending wallet address and the incoming payment. Internally, we should be able to differentiate whether a local quote or local payment happened under the hood. Keep in mind, the outgoing payment id references the current quote id (the outgoing payment id is actually equal to the quote id) Implement local quoting Aug 9, 2024
@mkurapov mkurapov moved this from Backlog to Todo in Rafiki Aug 9, 2024
@BlairCurrey BlairCurrey self-assigned this Aug 9, 2024
@BlairCurrey BlairCurrey moved this from Todo to In Progress in Rafiki Aug 9, 2024
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Rafiki Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants