feat(backend): add local payment #2857
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,147 @@ | ||
| /** | ||
| * @param { import("knex").Knex } knex | ||
| * @returns { Promise<void> } | ||
| */ | ||
| exports.up = function (knex) { | ||
| return ( | ||
| knex.schema | ||
| // Create new table with columns from "quotes" to migrate | ||
| .createTable('ilpQuoteDetails', function (table) { | ||
| table.uuid('id').notNullable().primary() | ||
| table.uuid('quoteId').notNullable().unique() | ||
| table.foreign('quoteId').references('quotes.id') | ||
|
|
||
| table.bigInteger('maxPacketAmount').notNullable() | ||
| table.decimal('minExchangeRateNumerator', 64, 0).notNullable() | ||
| table.decimal('minExchangeRateDenominator', 64, 0).notNullable() | ||
| table.decimal('lowEstimatedExchangeRateNumerator', 64, 0).notNullable() | ||
| table | ||
| .decimal('lowEstimatedExchangeRateDenominator', 64, 0) | ||
| .notNullable() | ||
| table.decimal('highEstimatedExchangeRateNumerator', 64, 0).notNullable() | ||
| table | ||
| .decimal('highEstimatedExchangeRateDenominator', 64, 0) | ||
| .notNullable() | ||
|
|
||
| table.timestamp('createdAt').defaultTo(knex.fn.now()) | ||
| table.timestamp('updatedAt').defaultTo(knex.fn.now()) | ||
| }) | ||
| .then(() => { | ||
| // Enable uuid_generate_v4 | ||
| return knex.raw(`CREATE EXTENSION IF NOT EXISTS "uuid-ossp";`) | ||
| }) | ||
| .then(() => { | ||
| // Migrate data from quotes to ilpQuoteDetails. | ||
| return knex.raw(` | ||
| INSERT INTO "ilpQuoteDetails" ( | ||
| id, | ||
| "quoteId", | ||
| "maxPacketAmount", | ||
| "minExchangeRateNumerator", | ||
| "minExchangeRateDenominator", | ||
| "lowEstimatedExchangeRateNumerator", | ||
| "lowEstimatedExchangeRateDenominator", | ||
| "highEstimatedExchangeRateNumerator", | ||
| "highEstimatedExchangeRateDenominator" | ||
| ) | ||
| SELECT | ||
| uuid_generate_v4(), | ||
| id AS "quoteId", | ||
| "maxPacketAmount", | ||
| "minExchangeRateNumerator", | ||
| "minExchangeRateDenominator", | ||
| "lowEstimatedExchangeRateNumerator", | ||
| "lowEstimatedExchangeRateDenominator", | ||
| "highEstimatedExchangeRateNumerator", | ||
| "highEstimatedExchangeRateDenominator" | ||
| FROM "quotes"; | ||
| `) | ||
| }) | ||
| .then(() => { | ||
| // TODO: test this more thoroughly. | ||
| // Might need to seed in migration preceeding this? | ||
| // Cant simply withold htis migration. Application code will fail when trying | ||
| // to insert ... | ||
| return knex('quotes') | ||
| .whereNull('estimatedExchangeRate') | ||
| .update({ | ||
| estimatedExchangeRate: knex.raw('?? / ??', [ | ||
| 'lowEstimatedExchangeRateNumerator', | ||
| 'lowEstimatedExchangeRateDenominator' | ||
| ]) | ||
| }) | ||
| }) | ||
| .then(() => { | ||
| return knex.schema.alterTable('quotes', function (table) { | ||
| table.dropColumn('maxPacketAmount') | ||
| table.dropColumn('minExchangeRateNumerator') | ||
| table.dropColumn('minExchangeRateDenominator') | ||
| table.dropColumn('lowEstimatedExchangeRateNumerator') | ||
| table.dropColumn('lowEstimatedExchangeRateDenominator') | ||
| table.dropColumn('highEstimatedExchangeRateNumerator') | ||
| table.dropColumn('highEstimatedExchangeRateDenominator') | ||
| }) | ||
| }) | ||
| ) | ||
| } | ||
|
|
||
| /** | ||
| * @param { import("knex").Knex } knex | ||
| * @returns { Promise<void> } | ||
| */ | ||
| exports.down = function (knex) { | ||
| return knex.schema | ||
| .alterTable('quotes', function (table) { | ||
| // restore columns without not null constraint | ||
| table.bigInteger('maxPacketAmount') | ||
| table.decimal('minExchangeRateNumerator', 64, 0) | ||
| table.decimal('minExchangeRateDenominator', 64, 0) | ||
| table.decimal('lowEstimatedExchangeRateNumerator', 64, 0) | ||
| table.decimal('lowEstimatedExchangeRateDenominator', 64, 0) | ||
| table.decimal('highEstimatedExchangeRateNumerator', 64, 0) | ||
| table.decimal('highEstimatedExchangeRateDenominator', 64, 0) | ||
| }) | ||
| .then(() => { | ||
| // Migrate data back to quotes table from ilpQuote | ||
| return knex.raw(` | ||
| UPDATE "quotes" | ||
| SET | ||
| "maxPacketAmount" = "ilpQuoteDetails"."maxPacketAmount", | ||
| "minExchangeRateNumerator" = "ilpQuoteDetails"."minExchangeRateNumerator", | ||
| "minExchangeRateDenominator" = "ilpQuoteDetails"."minExchangeRateDenominator", | ||
| "lowEstimatedExchangeRateNumerator" = "ilpQuoteDetails"."lowEstimatedExchangeRateNumerator", | ||
| "lowEstimatedExchangeRateDenominator" = "ilpQuoteDetails"."lowEstimatedExchangeRateDenominator", | ||
| "highEstimatedExchangeRateNumerator" = "ilpQuoteDetails"."highEstimatedExchangeRateNumerator", | ||
| "highEstimatedExchangeRateDenominator" = "ilpQuoteDetails"."highEstimatedExchangeRateDenominator" | ||
| FROM "ilpQuoteDetails" | ||
| WHERE "quotes"."id" = "ilpQuoteDetails"."quoteId" | ||
| `) | ||
| }) | ||
| .then(() => { | ||
| // Apply the not null constraints after data insertion | ||
| return knex.schema.alterTable('quotes', function (table) { | ||
| table.bigInteger('maxPacketAmount').notNullable().alter() | ||
| table.decimal('minExchangeRateNumerator', 64, 0).notNullable().alter() | ||
| table.decimal('minExchangeRateDenominator', 64, 0).notNullable().alter() | ||
| table | ||
| .decimal('lowEstimatedExchangeRateNumerator', 64, 0) | ||
| .notNullable() | ||
| .alter() | ||
| table | ||
| .decimal('lowEstimatedExchangeRateDenominator', 64, 0) | ||
| .notNullable() | ||
| .alter() | ||
| table | ||
| .decimal('highEstimatedExchangeRateNumerator', 64, 0) | ||
| .notNullable() | ||
| .alter() | ||
| table | ||
| .decimal('highEstimatedExchangeRateDenominator', 64, 0) | ||
| .notNullable() | ||
| .alter() | ||
| }) | ||
| }) | ||
| .then(() => { | ||
| return knex.schema.dropTableIfExists('ilpQuoteDetails') | ||
| }) | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this down will fail if local quotes are added before migration is rolled back run because they dont have these non null columns. We are setting back to null because that was the original state before the migration. What should we do?
IDK, not sure any of these options are great, but its also kind of an edge case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's split this up into multiple migrations, something like:
estimatedExchangeRate, and mark the field as requiredilpQuoteDetailsilpQuoteDetailsThen we deploy the code changes to start reading from
ilpQuoteDetailsquotesthis way, we dont run into the risk of losing data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I suppose multiple migrations make sense. More control over up/down if needed without downside.
In terms of this part:
Is the idea that we put the drop ilp fields from quotes in another release and communicate as much in patch notes? I mean I dont see a way to ensure integrators arent just upgrading multiple releases and running them all at once in that case. I guess this is still better and if some integrator does run into an issue we can fix it before we release the migration that will lose the data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this all will go in one release, I was just thinking of how to make the changes safely (or in separate PRs).
If you want, we can have this:
released the same time as we backfill
ilpQuoteDetails(anddrop ilp fields from quotesfor that matter)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thinking about it more, i dont think we can split the create ilpQuoteDetails table and the migration to backfill it.
if migrations are run through create ilpQuoteDetails (but not backfilled), and then quotes are created in the application with ilpQuoteDetails, then they are backfilled, then the quotes created via the application will try to be inserted again in the ilpQuoteDetails (and it will fail because the quoteId has a unique constraint). I think we need to enforce they are run together by keeping them in the same migration. I think splitting the other ones as described are still fine.