Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roots return arrays vs objects #185

Open
6 tasks
HRossouw42 opened this issue Apr 30, 2019 · 0 comments
Open
6 tasks

roots return arrays vs objects #185

HRossouw42 opened this issue Apr 30, 2019 · 0 comments

Comments

@HRossouw42
Copy link
Contributor

HRossouw42 commented Apr 30, 2019

  • roots that return arrays vs objects (one root must either return array or object, not both)
  • extract code within switch statements to separate functions
  • things that return arrays can't return 404's
  • returning 200's changed to object or array
  • functions that return arrays should use plural naming + vice versa
  • don't return boolean from a function. should be result or an error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants