Use pyproject.toml #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setuptools has [deprecated] the test command for the past five years and recently removed it. This caused [quite a stir] since many people's build broke. Our build of [pywb] failed because surt is still using setuptools.test. I thought perhaps this would be a good time to removing that dependency and given adoption of [PEP-621] perhaps now is a good time to switch over to using a `pyproject.toml` file? [deprecated]: pypa/setuptools#1684 [quite a stir]: pypa/setuptools#4519 [pywb]: https://github.com/webrecorder/pywb [PEP-621]: https://peps.python.org/pep-0621/
edsu
commented
Jul 29, 2024
| @@ -6,7 +6,7 @@ | |||
| [tox] | |||
| envlist = | |||
| py26, py27, | |||
| py33, py34, py35, py36 | |||
| py33, py34, py35, py36, py312 | |||
There was a problem hiding this comment.
I added this to verify that I can run the tests with tox.
|
Alternatively perhaps #34 is preferable if you'd rather not use pyproject.toml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setuptools has deprecated the test command for the past five years and recently removed it. This caused quite a stir since many people's builds broke.
Our build of pywb failed because surt is still using
setuptools.command.test. After the confusion setuptools decided to yank this version from pypi while they determine whether there is a less painful way to remove the test command.Perhaps this is a good time to remove the dependency on
setuptools.commands.test, and given adoption of PEP-621 also switch over to using apyproject.tomlfile?fixes #33