diff --git a/Gemfile b/Gemfile index 08c51de35b..0f2e855ab3 100644 --- a/Gemfile +++ b/Gemfile @@ -90,10 +90,9 @@ group :test do gem 'database_cleaner' gem 'minitest', '~> 5.17' gem 'minitest-stub_any_instance' + gem 'selenium-webdriver' gem 'simplecov', '0.17.1', require: false # CC last supported v0.17 gem 'spy' - # gem 'webdrivers' - gem 'selenium-webdriver' gem 'webmock' end diff --git a/app/interactions/actions/email_check.rb b/app/interactions/actions/email_check.rb index 44f0fb4146..8100293e2e 100644 --- a/app/interactions/actions/email_check.rb +++ b/app/interactions/actions/email_check.rb @@ -73,10 +73,10 @@ def handle_mx_validation(result) output_a_and_aaaa_validation_results(email: email, result: result_validation, type: 'AAAA') end - if result_validation.present? - result.success = true - result.errors.merge!({ mx: 'target host(s) not found, but was able to find A/AAAA records for domain'}) - end + return if result_validation.blank? + + result.success = true + result.errors.merge!({ mx: 'target host(s) not found, but was able to find A/AAAA records for domain' }) end def handle_saving_result(contact, result)