Skip to content

Commit

Permalink
fix: 'npm install' not working with PWA release zip file (#1314)
Browse files Browse the repository at this point in the history
* lazy components schematic needs git and a git repository but checked only for the git command not for being in a git repository
* if a downloaded PWA release zip file was used to build the PWA it no longer worked and failed at the ' npm install'
  • Loading branch information
shauke authored Nov 4, 2022
1 parent 9e77fba commit 33be4cc
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions schematics/src/helpers/lazy-components/factory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@ async function deleteOldComponents() {
if (process.env.CI !== 'true') {
let gitAvailable = false;
try {
cp.execSync('git --version');
cp.execSync('git status');
gitAvailable = true;
} catch (error) {
console.warn('Git is not installed. Skipping deletion.');
console.warn('Git is not installed or it is not a Git repository. Skipping deletion.');
}

if (gitAvailable) {
Expand Down

0 comments on commit 33be4cc

Please sign in to comment.