fix: improve mock data redirection for urls w/ matrix parameter

intershop · Nov 16, 2022 · 3d819e7 · 3d819e7
1 parent a98d391
commit 3d819e7
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 29 deletions.
diff --git a/src/app/core/interceptors/mock.interceptor.spec.ts b/src/app/core/interceptors/mock.interceptor.spec.ts
@@ -28,11 +28,15 @@ describe('Mock Interceptor', () => {
 
   describe('Request URL Modification', () => {
     it.each([
-      [`${BASE_URL}/categories/Cameras`, './assets/mock-data/categories/Cameras/get.json'],
-      [`${BASE_URL};loc=en_US;cur=USD/categories/Cameras`, './assets/mock-data/categories/Cameras/get.json'],
-      [`${BASE_URL}/categories?view=tree`, './assets/mock-data/categories/get.json'],
-      [`${BASE_URL};loc=en_US;cur=USD/categories?view=tree`, './assets/mock-data/categories/get.json'],
-      ['./assets/picture.png', './assets/picture.png'],
+      [`${BASE_URL}/categories/Cameras`, '/assets/mock-data/categories/Cameras/get.json'],
+      [`${BASE_URL};loc=en_US;cur=USD/categories/Cameras`, '/assets/mock-data/categories/Cameras/get.json'],
+      [`${BASE_URL}/categories?view=tree`, '/assets/mock-data/categories/get.json'],
+      [`${BASE_URL};loc=en_US;cur=USD/categories?view=tree`, '/assets/mock-data/categories/get.json'],
+      [
+        `${BASE_URL};loc=en_US;cur=USD/products;spgid=PU8jvEfUmFeE5k_3Hq1EE7DuxlIMC/1005182`,
+        '/assets/mock-data/products/1005182/get.json',
+      ],
+      ['/assets/picture.png', '/assets/picture.png'],
     ])('should replace request to "%s" with "%s"', (incoming, outgoing) => {
       const http = new HttpRequest('GET', incoming);
 
@@ -48,28 +52,31 @@ describe('Mock Interceptor', () => {
     });
   });
 
-  describe.each`
-    item                      | within                                    | expected
-    ${'categories'}           | ${undefined}                              | ${false}
-    ${'categories'}           | ${[]}                                     | ${false}
-    ${'categories'}           | ${['categories']}                         | ${true}
-    ${'catego'}               | ${['categories']}                         | ${false}
-    ${'categories'}           | ${['cat.*']}                              | ${true}
-    ${'product/cat'}          | ${['cat.*']}                              | ${true}
-    ${'product/38201833'}     | ${['2018']}                               | ${true}
-    ${'product/cat'}          | ${['^cat.*']}                             | ${false}
-    ${'categories/Computers'} | ${['categories$']}                        | ${false}
-    ${'categories/Computers'} | ${['categories.*']}                       | ${true}
-    ${'categories/Computers'} | ${['categories/.*']}                      | ${true}
-    ${'categories/Computers'} | ${['categories/Computers']}               | ${true}
-    ${'categories/Computers'} | ${['categories/Audio']}                   | ${false}
-    ${'categories/Computers'} | ${['categories/']}                        | ${true}
-    ${'categories/Computers'} | ${['categories/(Audio|Computers|HiFi)']}  | ${true}
-    ${'categories/Computers'} | ${['categories/(Audio|Computers|HiFi)/']} | ${false}
-    ${'categories/Computers'} | ${['Computers']}                          | ${true}
-  `(`matchPath Method`, ({ item, within, expected }) => {
-    it(`should be ${expected} for URL '${item}' and mock paths [${within}]`, () => {
-      expect(mockInterceptor.matchPath(item, within)).toBe(expected);
+  describe('matchPath Method', () => {
+    // eslint-disable-next-line jest/valid-title
+    describe.each`
+      item                      | within                                    | expected
+      ${'categories'}           | ${undefined}                              | ${false}
+      ${'categories'}           | ${[]}                                     | ${false}
+      ${'categories'}           | ${['categories']}                         | ${true}
+      ${'catego'}               | ${['categories']}                         | ${false}
+      ${'categories'}           | ${['cat.*']}                              | ${true}
+      ${'product/cat'}          | ${['cat.*']}                              | ${true}
+      ${'product/38201833'}     | ${['2018']}                               | ${true}
+      ${'product/cat'}          | ${['^cat.*']}                             | ${false}
+      ${'categories/Computers'} | ${['categories$']}                        | ${false}
+      ${'categories/Computers'} | ${['categories.*']}                       | ${true}
+      ${'categories/Computers'} | ${['categories/.*']}                      | ${true}
+      ${'categories/Computers'} | ${['categories/Computers']}               | ${true}
+      ${'categories/Computers'} | ${['categories/Audio']}                   | ${false}
+      ${'categories/Computers'} | ${['categories/']}                        | ${true}
+      ${'categories/Computers'} | ${['categories/(Audio|Computers|HiFi)']}  | ${true}
+      ${'categories/Computers'} | ${['categories/(Audio|Computers|HiFi)/']} | ${false}
+      ${'categories/Computers'} | ${['Computers']}                          | ${true}
+    `(``, ({ item, within, expected }) => {
+      it(`should be ${expected} for URL '${item}' and mock paths [${within}]`, () => {
+        expect(mockInterceptor.matchPath(item, within)).toBe(expected);
+      });
     });
   });
 });
diff --git a/src/app/core/interceptors/mock.interceptor.ts b/src/app/core/interceptors/mock.interceptor.ts
@@ -1,5 +1,6 @@
 import { HttpEvent, HttpHandler, HttpInterceptor, HttpRequest } from '@angular/common/http';
 import { Inject, Injectable } from '@angular/core';
+import { PRIMARY_OUTLET, Router } from '@angular/router';
 import { Store, select } from '@ngrx/store';
 import { Observable } from 'rxjs';
 
@@ -15,7 +16,7 @@ const MOCK_DATA_ROOT = './assets/mock-data';
 export class MockInterceptor implements HttpInterceptor {
   private restEndpoint: string;
 
-  constructor(@Inject(API_MOCK_PATHS) private apiMockPaths: string[], store: Store) {
+  constructor(@Inject(API_MOCK_PATHS) private apiMockPaths: string[], store: Store, private router: Router) {
     store.pipe(select(getRestEndpoint)).subscribe(data => (this.restEndpoint = data));
   }
 
@@ -27,7 +28,9 @@ export class MockInterceptor implements HttpInterceptor {
       return next.handle(req);
     }
 
-    const newUrl = `${MOCK_DATA_ROOT}/${this.getRestPath(req.url)}/${req.method.toLocaleLowerCase()}.json`;
+    const mockUrl = `${MOCK_DATA_ROOT}/${this.getRestPath(req.url)}/${req.method.toLocaleLowerCase()}.json`;
+    const commands = this.router.parseUrl(mockUrl)?.root?.children?.[PRIMARY_OUTLET]?.segments?.map(s => s.path);
+    const newUrl = this.router.createUrlTree(commands)?.toString();
 
     // eslint-disable-next-line no-console
     console.log(`redirecting '${req.url}' to '${newUrl}'`);