fix: missing display name for default sorting in product lists

intershop · Aug 9, 2022 · 5fb6ee9 · 5fb6ee9
1 parent 8fe342b
commit 5fb6ee9
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 3 deletions.
diff --git a/...app/shared/components/product/product-list-toolbar/product-list-toolbar.component.spec.ts b/...app/shared/components/product/product-list-toolbar/product-list-toolbar.component.spec.ts
@@ -1,6 +1,7 @@
 import { ComponentFixture, TestBed } from '@angular/core/testing';
 import { RouterTestingModule } from '@angular/router/testing';
 import { FaIconComponent } from '@fortawesome/angular-fontawesome';
+import { TranslateModule } from '@ngx-translate/core';
 import { MockComponent } from 'ng-mocks';
 
 import { ProductListToolbarComponent } from './product-list-toolbar.component';
@@ -13,7 +14,7 @@ describe('Product List Toolbar Component', () => {
   beforeEach(async () => {
     await TestBed.configureTestingModule({
       declarations: [MockComponent(FaIconComponent), ProductListToolbarComponent],
-      imports: [RouterTestingModule],
+      imports: [RouterTestingModule, TranslateModule.forRoot()],
     }).compileComponents();
   });
 

diff --git a/src/app/shared/components/product/product-list-toolbar/product-list-toolbar.component.ts b/src/app/shared/components/product/product-list-toolbar/product-list-toolbar.component.ts
@@ -1,5 +1,6 @@
 import { ChangeDetectionStrategy, Component, Input, OnChanges } from '@angular/core';
 import { ActivatedRoute, Router } from '@angular/router';
+import { TranslateService } from '@ngx-translate/core';
 
 import { SortableAttributesType } from 'ish-core/models/product-listing/product-listing.model';
 import { SelectOption } from 'ish-core/models/select-option/select-option.model';
@@ -22,7 +23,7 @@ export class ProductListToolbarComponent implements OnChanges {
 
   sortOptions: SelectOption[] = [];
 
-  constructor(private router: Router, private activatedRoute: ActivatedRoute) {}
+  constructor(private router: Router, private activatedRoute: ActivatedRoute, private translate: TranslateService) {}
 
   ngOnChanges() {
     this.sortOptions = this.mapSortableAttributesToSelectOptions(this.sortableAttributes);
@@ -44,7 +45,7 @@ export class ProductListToolbarComponent implements OnChanges {
       .filter(x => !!x)
       .map(sk => ({ value: sk.name, label: sk.displayName || sk.name }))
       .sort((a, b) => a.label.localeCompare(b.label));
-    options.unshift({ value: 'default', label: undefined });
+    options.unshift({ value: 'default', label: this.translate.instant('product.items.sorting.default.label') });
     return options;
   }
 

diff --git a/src/assets/i18n/de_DE.json b/src/assets/i18n/de_DE.json
@@ -853,6 +853,7 @@
   "product.instock.text": "Verfügbar",
   "product.itemNumber.label": "Artikelnummer:",
   "product.items.label": "{{0, plural, one{# Element} other{# Elemente}}}",
+  "product.items.sorting.default.label": "Standardsortierung",
   "product.manufacturer_name.label": "Herstellername",
   "product.out_of_stock.text": "Nicht verfügbar",
   "product.price.listPriceFallback.text": "{{0}}",

diff --git a/src/assets/i18n/en_US.json b/src/assets/i18n/en_US.json
@@ -853,6 +853,7 @@
   "product.instock.text": "In Stock",
   "product.itemNumber.label": "Product ID:",
   "product.items.label": "{{0, plural, one{# list item} other{# list items}}}",
+  "product.items.sorting.default.label": "Default Sorting",
   "product.manufacturer_name.label": "Manufacturer Name",
   "product.out_of_stock.text": "Out of Stock",
   "product.price.listPriceFallback.text": "{{0}}",

diff --git a/src/assets/i18n/fr_FR.json b/src/assets/i18n/fr_FR.json
@@ -853,6 +853,7 @@
   "product.instock.text": "En stock",
   "product.itemNumber.label": "ID produit :",
   "product.items.label": "{{0, plural, one{# article} other{# articles}}}",
+  "product.items.sorting.default.label": "Tri par défaut",
   "product.manufacturer_name.label": "Nom du fabricant",
   "product.out_of_stock.text": "Stock épuisé",
   "product.price.listPriceFallback.text": "{{0}}",