Skip to content

Commit

Permalink
deps: update to angular 14 and fix issues
Browse files Browse the repository at this point in the history
BREAKING CHANGES: Angular 14 and dependecies update (see [Migrations / 2.4 to 3.0](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#24-to-30) for more details).
  • Loading branch information
MaxKless authored and SGrueber committed Jul 19, 2022
1 parent 8087fa7 commit c216537
Show file tree
Hide file tree
Showing 36 changed files with 7,512 additions and 12,158 deletions.
6 changes: 3 additions & 3 deletions angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"intershop-pwa": {
"projectType": "application",
"cli": {
"defaultCollection": "intershop-schematics"
"schematicCollections": ["intershop-schematics"]
},
"schematics": {
"@schematics/angular:component": {
Expand Down Expand Up @@ -185,7 +185,7 @@
"organization-management": {
"projectType": "application",
"cli": {
"defaultCollection": "intershop-schematics"
"schematicCollections": ["intershop-schematics"]
},
"root": "projects/organization-management",
"sourceRoot": "projects/organization-management/src",
Expand Down Expand Up @@ -234,7 +234,7 @@
"requisition-management": {
"projectType": "application",
"cli": {
"defaultCollection": "intershop-schematics"
"schematicCollections": ["intershop-schematics"]
},
"root": "projects/requisition-management",
"sourceRoot": "projects/requisition-management/src",
Expand Down
8 changes: 8 additions & 0 deletions docs/guides/migrations.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,14 @@ kb_sync_latest_only
The Intershop PWA 3.0 release includes a Jest Update to version 28, see also https://jestjs.io/docs/upgrading-to-jest28.
The jest-marbles package has been replaced by jasmine-marbles.

It also contains the Angular 14 update and updates to a lot of other dependencies (NgRx, Typescript).
These updates require some code adaptions, e.g. form classes have been prefixed with _Untyped_ wherever necessary.
The following official guides might help to migrate custom code as well:

- https://update.angular.io/?v=13.0-14.0
- https://ngrx.io/guide/migration/v14
- https://angular.io/guide/typed-forms

Since the used deferred load library is no longer maintained it is removed and replaced with similar standard browser functionality [`loading="lazy"`](https://developer.mozilla.org/en-US/docs/Web/Performance/Lazy_loading#images_and_iframes).
All uses of the `(deferLoad)` directive in custom code need to be replaced.

Expand Down
2 changes: 1 addition & 1 deletion e2e/test-universal.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ universalTest 7 "${PWA_BASE_URL}/catComputers.1835.151" "add-to-compare"
universalTest 8 "${PWA_BASE_URL}/home" "intershop-pwa-state"
universalTest 9 "${PWA_BASE_URL}/home" "&q;baseURL&q;:"
universalTest 10 "${PWA_BASE_URL}/home" "<ish-content-include includeid=.include.homepage.content.pagelet2-Include"
universalTest 11 "${PWA_BASE_URL}/home" "<link rel=.canonical. href=.${PWA_CANONICAL_BASE_URL}/home.>"
universalTest 11 "${PWA_BASE_URL}/home" "<link rel=.canonical. href=.${PWA_CANONICAL_BASE_URL}/home/.>"
universalTest 12 "${PWA_BASE_URL}/home" "<meta property=.og:image. content=./assets/img/og-image-default"
universalTest 13 "${PWA_BASE_URL}/home" "<title>inTRONICS Home | Intershop PWA</title>"
universalTest 14 "${PWA_BASE_URL}/sku6997041" "<link rel=.canonical. href=.${PWA_CANONICAL_BASE_URL}/Notebooks/Asus-Eee-PC-1008P-Karim-Rashid-sku6997041-catComputers.1835.151.>"
Expand Down
Loading

0 comments on commit c216537

Please sign in to comment.