fix: prevent validation error when closing dialogs (#1617)

* do not show validation error after submitting the wish list/order template form * do not show validation error after saving data when rejecting a requisition in dialogs
intershop · Mar 27, 2024 · f14f8aa · f14f8aa
1 parent 4e06b47
commit f14f8aa
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/...pages/requisition-detail/requisition-reject-dialog/requisition-reject-dialog.component.ts b/...pages/requisition-detail/requisition-reject-dialog/requisition-reject-dialog.component.ts
@@ -86,12 +86,12 @@ export class RequisitionRejectDialogComponent implements OnInit {
 
   /** Opens the modal. */
   show() {
+    this.rejectForm.reset();
     this.modal = this.ngbModal.open(this.modalTemplate);
   }
 
   /** Close the modal. */
   hide() {
-    this.rejectForm.reset();
     this.submitted = false;
     if (this.modal) {
       this.modal.close();

diff --git a/...s/shared/order-template-preferences-dialog/order-template-preferences-dialog.component.ts b/...s/shared/order-template-preferences-dialog/order-template-preferences-dialog.component.ts
@@ -112,15 +112,13 @@ export class OrderTemplatePreferencesDialogComponent implements OnInit {
 
   /** Opens the modal. */
   show() {
-    if (this.orderTemplate) {
-      this.model = pick(this.orderTemplate, 'title');
-    }
+    this.orderTemplateForm.reset();
+    this.model = pick(this.orderTemplate, 'title');
     this.modal = this.ngbModal.open(this.modalTemplate);
   }
 
   /** Close the modal. */
   hide() {
-    this.orderTemplateForm.reset({});
     this.submitted = false;
     if (this.modal) {
       this.modal.close();

diff --git a/...ons/wishlists/shared/wishlist-preferences-dialog/wishlist-preferences-dialog.component.ts b/...ons/wishlists/shared/wishlist-preferences-dialog/wishlist-preferences-dialog.component.ts
@@ -126,6 +126,7 @@ export class WishlistPreferencesDialogComponent implements OnInit {
 
   /** Opens the modal. */
   show() {
+    this.wishListForm.reset();
     if (!this.wishlist) {
       this.model = { preferred: false };
     } else {
@@ -136,7 +137,6 @@ export class WishlistPreferencesDialogComponent implements OnInit {
 
   /** Close the modal. */
   hide() {
-    this.wishListForm.reset();
     this.submitted = false;
     if (this.modal) {
       this.modal.close();