Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load locales from ICM-Configuration #684

Closed
Eisie96 opened this issue May 7, 2021 · 0 comments · Fixed by #685
Closed

Load locales from ICM-Configuration #684

Eisie96 opened this issue May 7, 2021 · 0 comments · Fixed by #685
Labels
enhancement Enhancement to an existing feature feature New feature or request
Milestone
0.31

Comments

@Eisie96
Copy link
Contributor

Eisie96 commented May 7, 2021

Is your feature request related to a problem? If yes, please describe it.

The PWA should use only the configured locales from the ICM-Backend

Describe the desired solution.

Load the configurations incl. the locales from the ICM. These are now the available locales. Configured locales in environment.ts could be removed.

Describe alternatives you've considered.

It is suitable that a fallback locale is configured in environment.ts, when the configuration from the ICM is not available.
@Eisie96 Eisie96 added enhancement Enhancement to an existing feature feature New feature or request labels May 7, 2021
@Eisie96 Eisie96 mentioned this issue May 7, 2021
Merged
3 tasks
@shauke shauke added this to the 0.31 milestone May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhancement to an existing feature feature New feature or request
Projects
None yet
Milestone
0.31
Development

Successfully merging a pull request may close this issue.

feat: use locales from ICM configuration intershop/intershop-pwa
2 participants
@Eisie96 @shauke