-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: complex configuration can be supplied as yaml #1133
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
added
enhancement
Enhancement to an existing feature
community
Community contributions
labels
Apr 18, 2022
dhhyi
force-pushed
the
refactor/variable-for-platform-id
branch
from
April 21, 2022 14:26
48a8305
to
a02d847
Compare
dhhyi
force-pushed
the
feat/complex-config-as-yaml
branch
from
April 21, 2022 14:27
012ea8f
to
9a04d44
Compare
dhhyi
force-pushed
the
refactor/variable-for-platform-id
branch
from
May 2, 2022 07:43
a02d847
to
20b86e5
Compare
dhhyi
force-pushed
the
feat/complex-config-as-yaml
branch
from
May 2, 2022 07:45
9a04d44
to
659f4b9
Compare
dhhyi
force-pushed
the
refactor/variable-for-platform-id
branch
from
May 17, 2022 12:40
20b86e5
to
f1511da
Compare
dhhyi
force-pushed
the
feat/complex-config-as-yaml
branch
2 times, most recently
from
May 20, 2022 12:15
12d64c7
to
5ac0732
Compare
dhhyi
force-pushed
the
refactor/variable-for-platform-id
branch
from
June 6, 2022 09:22
add309b
to
c3cf255
Compare
dhhyi
force-pushed
the
feat/complex-config-as-yaml
branch
from
June 6, 2022 09:24
5ac0732
to
69a58e5
Compare
dhhyi
force-pushed
the
feat/complex-config-as-yaml
branch
2 times, most recently
from
June 27, 2022 14:06
bb36aca
to
e9b8d9b
Compare
dhhyi
force-pushed
the
refactor/variable-for-platform-id
branch
from
July 12, 2022 14:21
18a00ce
to
6b9929d
Compare
dhhyi
force-pushed
the
feat/complex-config-as-yaml
branch
from
July 12, 2022 14:22
e9b8d9b
to
b949e2d
Compare
dhhyi
force-pushed
the
feat/complex-config-as-yaml
branch
from
July 20, 2022 09:16
b949e2d
to
9e817ad
Compare
dhhyi
force-pushed
the
feat/complex-config-as-yaml
branch
from
July 21, 2022 07:55
9e817ad
to
68f3a8d
Compare
dhhyi
force-pushed
the
feat/complex-config-as-yaml
branch
from
July 22, 2022 09:53
68f3a8d
to
99dada8
Compare
dhhyi
force-pushed
the
feat/complex-config-as-yaml
branch
2 times, most recently
from
July 22, 2022 10:37
a94ee70
to
366742b
Compare
dhhyi
force-pushed
the
feat/complex-config-as-yaml
branch
from
July 22, 2022 10:39
366742b
to
bfe006f
Compare
MaxKless
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
What Is the Current Behavior?
Complex configurations for
IDENTITY_PROVIDER
orTACTON
have to be supplied as JSON to the deployments:When trying to structure the data, it becomes very verbose and even then JSON parsing is very sensitive to commas and quotes and therefore prone to error:
What Is the New Behavior?
Complex configuration can be supplied as YAML:
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
Depends on integration of #1080, so that
js-yaml
is only included into the server bundle.AB#78387