Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: complex configuration can be supplied as yaml #1133

Merged
merged 3 commits into from
Jul 22, 2022

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Apr 18, 2022

PR Type

[x] Feature

What Is the Current Behavior?

Complex configurations for IDENTITY_PROVIDER or TACTON have to be supplied as JSON to the deployments:

  IDENTITY_PROVIDERS: |
    { "Auth0": { "type": "auth0", "domain": "dev-asdf1234.eu.auth0.com", "clientID": "012ea8f1db7a838b65a8b29e8464742166877abb" } }

When trying to structure the data, it becomes very verbose and even then JSON parsing is very sensitive to commas and quotes and therefore prone to error:

  IDENTITY_PROVIDERS: |
    { 
      "Auth0": { 
        "type": "auth0",
        "domain": "dev-asdf1234.eu.auth0.com",
        "clientID": "012ea8f1db7a838b65a8b29e8464742166877abb"
      }
    }

What Is the New Behavior?

Complex configuration can be supplied as YAML:

  IDENTITY_PROVIDERS: |
    Auth0:
      type: auth0
      domain: dev-asdf1234.eu.auth0.com
      clientID: 012ea8f1db7a838b65a8b29e8464742166877abb

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

Depends on integration of #1080, so that js-yaml is only included into the server bundle.

AB#78387

@dhhyi dhhyi added enhancement Enhancement to an existing feature community Community contributions labels Apr 18, 2022
@dhhyi dhhyi self-assigned this Apr 18, 2022
@dhhyi dhhyi added the wait Waiting for something (e.g. new ICM release) label Apr 18, 2022
@dhhyi dhhyi force-pushed the refactor/variable-for-platform-id branch from 48a8305 to a02d847 Compare April 21, 2022 14:26
@dhhyi dhhyi force-pushed the feat/complex-config-as-yaml branch from 012ea8f to 9a04d44 Compare April 21, 2022 14:27
@dhhyi dhhyi force-pushed the refactor/variable-for-platform-id branch from a02d847 to 20b86e5 Compare May 2, 2022 07:43
@dhhyi dhhyi force-pushed the feat/complex-config-as-yaml branch from 9a04d44 to 659f4b9 Compare May 2, 2022 07:45
@dhhyi dhhyi force-pushed the refactor/variable-for-platform-id branch from 20b86e5 to f1511da Compare May 17, 2022 12:40
@dhhyi dhhyi force-pushed the feat/complex-config-as-yaml branch 2 times, most recently from 12d64c7 to 5ac0732 Compare May 20, 2022 12:15
@dhhyi dhhyi force-pushed the refactor/variable-for-platform-id branch from add309b to c3cf255 Compare June 6, 2022 09:22
@dhhyi dhhyi force-pushed the feat/complex-config-as-yaml branch from 5ac0732 to 69a58e5 Compare June 6, 2022 09:24
@dhhyi dhhyi force-pushed the feat/complex-config-as-yaml branch 2 times, most recently from bb36aca to e9b8d9b Compare June 27, 2022 14:06
@dhhyi dhhyi force-pushed the refactor/variable-for-platform-id branch from 18a00ce to 6b9929d Compare July 12, 2022 14:21
@dhhyi dhhyi force-pushed the feat/complex-config-as-yaml branch from e9b8d9b to b949e2d Compare July 12, 2022 14:22
Base automatically changed from refactor/variable-for-platform-id to develop July 19, 2022 14:00
@dhhyi dhhyi force-pushed the feat/complex-config-as-yaml branch from b949e2d to 9e817ad Compare July 20, 2022 09:16
@dhhyi dhhyi marked this pull request as ready for review July 20, 2022 09:17
@dhhyi dhhyi removed wait Waiting for something (e.g. new ICM release) has conflicts labels Jul 20, 2022
@dhhyi dhhyi requested a review from shauke July 20, 2022 09:17
@dhhyi dhhyi removed their assignment Jul 20, 2022
@dhhyi dhhyi requested a review from MaxKless July 20, 2022 09:26
@dhhyi dhhyi force-pushed the feat/complex-config-as-yaml branch from 9e817ad to 68f3a8d Compare July 21, 2022 07:55
@MaxKless MaxKless self-assigned this Jul 21, 2022
@MaxKless MaxKless added this to the 3.0 milestone Jul 21, 2022
@dhhyi dhhyi force-pushed the feat/complex-config-as-yaml branch from 68f3a8d to 99dada8 Compare July 22, 2022 09:53
@dhhyi dhhyi force-pushed the feat/complex-config-as-yaml branch 2 times, most recently from a94ee70 to 366742b Compare July 22, 2022 10:37
@dhhyi dhhyi force-pushed the feat/complex-config-as-yaml branch from 366742b to bfe006f Compare July 22, 2022 10:39
@MaxKless MaxKless merged commit 4a71df7 into develop Jul 22, 2022
@MaxKless MaxKless deleted the feat/complex-config-as-yaml branch July 22, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contributions enhancement Enhancement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants