chore: remove unused http-loader dep #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, that seems like a good idea. I'm definitely against keeping deps for projects but if that PR makes it into the standard, we can keep it around for now. |
shauke
force-pushed
the
chore/remove-unused-dep
branch
2 times, most recently
from
7a3bec8 to
b837c9e
Compare
|
Removed the dependency since we did not merge #927. We added a documentation reference to the PR though. |
shauke
previously approved these changes
Jul 12, 2022
…n external source
shauke
force-pushed
the
chore/remove-unused-dep
branch
from
b837c9e to
4be956f
Compare
shauke
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
running
npx depcheckshowed an unused dependency, which is a leftover from one of the many translation reworks.I removed it.
AB#76562