Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Angular A11y ESLint Rules (Accessibility) #1168

Merged
merged 3 commits into from
Jul 29, 2022

Conversation

SGrueber
Copy link
Collaborator

@SGrueber SGrueber commented May 20, 2022

PR Type

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

No es-lint rules are used to enforce accessibility within angular component templates.

Issue Number: Closes #

What Is the New Behavior?

We added some es-lint rules to improve the accessibility behavior.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

For more information see also
Angular A11y ESLint Rules
Build more accessible apps in Angular

AB#76851

@SGrueber SGrueber added this to the 3.0 milestone Jul 19, 2022
@SGrueber SGrueber marked this pull request as ready for review July 21, 2022 06:54
@jometzner jometzner self-requested a review July 25, 2022 12:27
@jometzner jometzner assigned jometzner and unassigned SGrueber Jul 25, 2022
@SGrueber SGrueber force-pushed the feature/accessibility_eslint_rules branch from c38bce1 to 900a2ca Compare July 26, 2022 11:36
@SGrueber SGrueber added enhancement Enhancement to an existing feature and removed has conflicts labels Jul 26, 2022
@SGrueber SGrueber force-pushed the feature/accessibility_eslint_rules branch from f5a553f to d73b793 Compare July 29, 2022 08:42
@SGrueber SGrueber force-pushed the feature/accessibility_eslint_rules branch from d73b793 to 76d045d Compare July 29, 2022 09:34
@SGrueber SGrueber requested a review from jometzner July 29, 2022 09:35
@jometzner jometzner merged commit e584271 into develop Jul 29, 2022
@jometzner jometzner deleted the feature/accessibility_eslint_rules branch July 29, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants