Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: static page component needs to load the content page tree for the breadcrumb even if the navigation is not shown #1215

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

shauke
Copy link
Collaborator

@shauke shauke commented Jul 18, 2022

PR Type

[x] Bugfix

What Is the Current Behavior?

Currently the cms-static-page rendering component does not render the breadcrumb correctly if the content page navigation is not shown since it only fetches the needed information when configured to show the navigation.

What Is the New Behavior?

The content page hierarchy information is now fetched for all cms-static-page components no matter if a left navigation is shown or not.

Does this PR Introduce a Breaking Change?

[x] No

Other Information

AB#78293

@shauke shauke added this to the 3.0 milestone Jul 18, 2022
@shauke shauke self-assigned this Jul 18, 2022
@shauke shauke requested a review from Eisie96 July 18, 2022 16:59
@shauke shauke force-pushed the refactor/improve-content-pages-url branch from 63eff5c to 8a62efc Compare July 18, 2022 18:32
@shauke shauke force-pushed the refactor/improve-content-pages-url branch from 8a62efc to ff75ee0 Compare July 19, 2022 15:21
Base automatically changed from refactor/improve-content-pages-url to develop July 19, 2022 15:26
@shauke shauke force-pushed the bugfix/cms-static-content-breadcrumb branch from 0ebd251 to 1c57165 Compare July 19, 2022 15:39
…e breadcrumb even if the navigation is not shown (#1215)
@shauke shauke force-pushed the bugfix/cms-static-content-breadcrumb branch from 1c57165 to 321cf52 Compare July 19, 2022 15:46
@shauke shauke merged commit 51275d5 into develop Jul 19, 2022
@shauke shauke deleted the bugfix/cms-static-content-breadcrumb branch July 19, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants