fix: show success messages for cost center buyer actions (#959) #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe the content of the messages should be more precise: |
SGrueber
requested changes
Aug 18, 2022
| updateCostCenterBuyerSuccess({ costCenter }), | ||
| displaySuccessMessage({ | ||
| message: 'account.organization.cost_center_management.buyer.update.confirmation', | ||
| messageParams: { 0: `${payload.buyer.login}` }, |
There was a problem hiding this comment.
${payload.buyer.firstName} ${payload.buyer.lastName} || ${payload.buyer.login}
to make it work the firstName and lastName has to be added to the CostCenterBuyer object in the method submitCostCenterBuyerForm() of the cost-center-buyer-edit-dialog.component
DiverDori
force-pushed
the
fix/show-costcenterbuyer-success-messages
branch
from
73e7d87 to
4eed7fc
Compare
SGrueber
previously approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
There are no success messages for actions with cost center users. #959
Issue Number: Closes #959
What Is the New Behavior?
There are new success messages for cost center users, in particular for adding, removing and updating the buyer.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x ] No
Other Information
AB#78898