fix: render product descriptions with images properly #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use `ishServerHtml` directive to handle embedded image resources
…source format (#1263) * images are no longer embedded with `ismediaobject` markers after TinyMCE update * added handling for simple relative image URLs into the '/INTERSHOP/' static file system
shauke
force-pushed
the
bugfix/product_descriptions_with_images
branch
from
38838a2 to
abf4d73
Compare
shauke
force-pushed
the
bugfix/product_descriptions_with_images
branch
from
abf4d73 to
b75974f
Compare
shauke
force-pushed
the
bugfix/product_descriptions_with_images
branch
from
b75974f to
2976009
Compare
Eisie96
previously approved these changes
Sep 1, 2022
…product detail pages (#1263) Co-authored-by: Marcel Eisentraut <meisentraut@intershop.de>
shauke
force-pushed
the
bugfix/product_descriptions_with_images
branch
from
56c111d to
8a2f12f
Compare
shauke
added a commit
that referenced
this pull request
Sep 2, 2022
* use `ishServerHtml` directive to handle embedded image resources
shauke
added a commit
that referenced
this pull request
Sep 2, 2022
…source format (#1263) * images are no longer embedded with `ismediaobject` markers after TinyMCE update * added handling for simple relative image URLs into the '/INTERSHOP/' static file system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ishServerHtmldirective to handle embedded image resourcesPR Type
[x] Bugfix
What Is the Current Behavior?
ishServerHtmldirective does not handle ICM embedded images withoutismediaobjectnotation. TinyMCE embedding format after update just uses simple relative URLs in the Intershop static file systemWhat Is the New Behavior?
ishServerHtmldirective.ishServerHtmldirective handles ICM embedded images withoutismediaobjectnotation.Does this PR Introduce a Breaking Change?
[x] No
Other Information
AB#79244