Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for two separate applications in hybrid mode #1289

Merged
merged 4 commits into from
Oct 12, 2022

Conversation

jometzner
Copy link
Collaborator

@jometzner jometzner commented Oct 5, 2022

PR Type

[ ] Bugfix
[ X ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

Currently you can use the hybrid mode (see below) only with one application. This has drawbacks as PWA uses the application denoted by rest and the classic storefront uses -. Certain aspects of ICM are managed application specific (e.g. CMS data) making it mandatory to merge the two applications into one. To much effort.

What Is the New Behavior?

You can specify the used hybrid application identifier in your environment.ts or theme-specific environment.<theme>.ts with key hybridApplication.

export const environment: Environment = {
  ...ENVIRONMENT_DEFAULTS,

  icmChannel: 'inSPIRED-inTRONICS_Business-Site',
  icmApplication: 'rest',
  hybridApplication: '-',

Does this PR Introduce a Breaking Change?

[ ] Yes
[ X ] No

Other Information

Hybrid mode is where PWA and classic storefront are used side-by-side. See hybrid-approach.md

AB#80090

@jometzner jometzner changed the title feat: support for two separate applications for hybrid mode feat: support for two separate applications in hybrid mode Oct 5, 2022
@jometzner jometzner force-pushed the feature/support-two-app-hybrid-mode branch 2 times, most recently from 5faf810 to c5897e4 Compare October 5, 2022 13:26
@jometzner jometzner force-pushed the feature/support-two-app-hybrid-mode branch from c5897e4 to d38568c Compare October 5, 2022 14:01
@jometzner jometzner requested a review from shauke October 7, 2022 08:34
@jometzner jometzner added the feature New feature or request label Oct 7, 2022
@jometzner jometzner added this to the 3.1 milestone Oct 7, 2022
@github-actions
Copy link

github-actions bot commented Oct 10, 2022

Azure Demo Servers are available:

shauke
shauke previously approved these changes Oct 11, 2022
@jometzner jometzner merged commit 6b99953 into develop Oct 12, 2022
@jometzner jometzner deleted the feature/support-two-app-hybrid-mode branch October 12, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants