Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: equality validation of input fields #1297

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

SGrueber
Copy link
Collaborator

@SGrueber SGrueber commented Oct 12, 2022

PR Type

[x] Bugfix

What Is the Current Behavior?

Validation of confirmation input fields does not work properly, like the confirmation of the email address or password.

Steps to Repeat

User registration:

  1. Enter a value in 1st email address field, e.g. "line1@line1.de"
  2. Enter a value in 2nd email address in confirmation field, e.g. "line2@line2.de" -> Validation correctly discovers a mismatch
  3. Now enter another value in 1st email address field , e.g. "different1@different1.de" ( which does not match the value in line 2 "line2@line2.de" ) -> The validation is not happening, no mismatch is discovered

What Is the New Behavior?

The validation works properly

Does this PR Introduce a Breaking Change?

[x] No

Other Information

AB#80264

@SGrueber SGrueber force-pushed the bugfix/validator_equalToControl branch from ab6bf60 to 4366965 Compare October 12, 2022 08:59
@SGrueber SGrueber requested review from shauke and jometzner October 12, 2022 09:01
@SGrueber SGrueber self-assigned this Oct 12, 2022
@SGrueber SGrueber added this to the 3.1 milestone Oct 12, 2022
@shauke shauke force-pushed the bugfix/validator_equalToControl branch from 4366965 to fa5017b Compare October 12, 2022 16:07
@shauke shauke merged commit 7895931 into develop Oct 12, 2022
@shauke shauke deleted the bugfix/validator_equalToControl branch October 12, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants