fix: add matrix parameter spgid to promotion REST calls #1310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
If a promotion is only valid for registered customers the get /promotions/id REST call ends up with a 404 (not found)
Issue Number: Closes #
What Is the New Behavior?
The matrix parameter spgid is added to the promotions REST call, so the REST call returns data without errors even if the promotion is only valid for registered users.
Steps to repeat
'Registered_1_37_off_for_5816351' inTRONICS Business promotion (1.37 value off for SKU 5816351 for registered users)
-> the get promotions/Registered_1_37_off_for_5816351 call shows a 404 error
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
AB#80536
AB#80473