Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add matrix parameter spgid to promotion REST calls #1310

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

SGrueber
Copy link
Collaborator

@SGrueber SGrueber commented Oct 21, 2022

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

If a promotion is only valid for registered customers the get /promotions/id REST call ends up with a 404 (not found)

Issue Number: Closes #

What Is the New Behavior?

The matrix parameter spgid is added to the promotions REST call, so the REST call returns data without errors even if the promotion is only valid for registered users.

Steps to repeat

  1. Create a promotion in the ICM backoffice that is only valid for registered users, e.g.
    'Registered_1_37_off_for_5816351' inTRONICS Business promotion (1.37 value off for SKU 5816351 for registered users)
  2. Clear pagecache
  3. Login into the pwa b2b storefront
  4. search for product 5816351 and check the network protocol
    -> the get promotions/Registered_1_37_off_for_5816351 call shows a 404 error

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#80536
AB#80473

@SGrueber SGrueber self-assigned this Oct 21, 2022
@SGrueber SGrueber requested a review from Eisie96 October 21, 2022 11:23
@SGrueber SGrueber added the bug Something isn't working label Oct 21, 2022
@SGrueber SGrueber added this to the 3.2 milestone Oct 21, 2022
@SGrueber SGrueber merged commit 1cae0d8 into develop Oct 21, 2022
@SGrueber SGrueber deleted the bugfix/personalized_promotion_calls branch October 21, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants