Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display login modal after authentication token has expired #1311

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

SGrueber
Copy link
Collaborator

@SGrueber SGrueber commented Oct 24, 2022

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

Precondition

SSR is switched on (production mode)

What Is the Current Behavior?

After a user logged in and the authentication token expired an empty login modal is displayed. If the user clicks inside the modal the content of the modal is shown.

Issue Number: Closes #1280

What Is the New Behavior?

The login modal is displayed with content immediately after the authentication token has expired.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#80567

@SGrueber SGrueber requested a review from dhhyi October 24, 2022 11:33
@SGrueber SGrueber self-assigned this Oct 24, 2022
@SGrueber SGrueber requested a review from shauke October 24, 2022 11:34
@SGrueber SGrueber added this to the 3.2 milestone Oct 24, 2022
dhhyi
dhhyi previously approved these changes Oct 24, 2022
Copy link
Collaborator

@shauke shauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not see the effect of ngbAutofocus but everything else looks good.

@shauke shauke merged commit 025818c into develop Nov 1, 2022
@shauke shauke deleted the fix/login_modal_after_timeout branch November 1, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty modal on production mode when apiToken vanishes
3 participants