Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: keep the footer at the bottom of the page #1318

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

tbouliere-datasolution
Copy link
Contributor

Due to the asynchronous loading of the pages, the footer sometimes goes up to the header. A pre-sizing of the main container avoids this unpleasant effect

PR Type

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

Issue Number: Closes #

What Is the New Behavior?

Does this PR Introduce a Breaking Change?

[ ] Yes
[ ] No

Other Information

Due to the asynchronous loading of the pages, the footer sometimes goes up to the header. A
pre-sizing of the main container avoids this unpleasant effect
@shauke shauke added this to the 3.2 milestone Nov 8, 2022
@shauke shauke self-assigned this Nov 8, 2022
shauke
shauke previously approved these changes Nov 8, 2022
@shauke shauke merged commit feb1648 into intershop:develop Nov 9, 2022
@shauke
Copy link
Collaborator

shauke commented Nov 9, 2022

Thank you for your nice contribution. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants