Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: my Account menu navigation grouping #1331

Merged
merged 14 commits into from
Feb 23, 2023
Merged

feat: my Account menu navigation grouping #1331

merged 14 commits into from
Feb 23, 2023

Conversation

tdonthu
Copy link
Contributor

@tdonthu tdonthu commented Nov 24, 2022 •
edited by shauke
Loading

PR Type

[x] Feature

What Is the Current Behavior?

Menu navigation in My Account page is currently displayed as a plain listing without any hierarchy/grouping.

What Is the New Behavior?

Menu navigation in My Account page will display group wise for B2B similar to the Responsive Starter Store.
The plain listing is kept for the B2C theme.

image

Does this PR Introduce a Breaking Change?

[x] Yes

Changed NavigationItem data structure and handling (see migration notes).

Other Information

AB#81337

@tdonthu tdonthu requested a review from shauke November 24, 2022 08:06
@shauke shauke self-assigned this Nov 28, 2022
@shauke shauke added this to the 3.3 milestone Dec 9, 2022
@shauke shauke force-pushed the feature-my_Account_menu_navigation_grouping branch from 7b49a9a to c06e864 Compare January 30, 2023 21:31
@github-actions
Copy link

Azure Demo Servers are available:

@5t3v3n-H 5t3v3n-H modified the milestones: 3.3, 4.0 Feb 1, 2023
@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Azure Demo Servers are available:

@shauke shauke force-pushed the feature-my_Account_menu_navigation_grouping branch 2 times, most recently from 43a5000 to 1e1ecbb Compare February 3, 2023 17:21
@shauke shauke requested a review from SGrueber February 4, 2023 19:34
@shauke shauke added the enhancement Enhancement to an existing feature label Feb 4, 2023
@github-actions
Copy link

github-actions bot commented Feb 4, 2023

Azure Demo Servers are available:

@SGrueber
Copy link
Collaborator

SGrueber commented Feb 6, 2023 •
edited
Loading

It would be good if the first menu item is always expanded after the user logged in. This might help the user to see that there are more options in the menu than he can see at first glance.
If the menu is collapsed lines are missing between the navigation items.
Under Approvals there will be only one item because we show the different lists on tabs. Under my profile we also have only 1 item. The partitioning of the menu has to be discussed again.

@shauke shauke requested review from iwiederhold and schadii February 6, 2023 09:09
@shauke
Copy link
Collaborator

shauke commented Feb 6, 2023

@iwiederhold @schadii Please review the changed Account Navigation if it meets your ideas. Please consider and answer the issues Silke addressed in her review. Styling was already discussed, so the missing lines are currently intended, but could be changed if necessary. Especially the partitioning should probably be discussed. Thank you.

iwiederhold
iwiederhold previously approved these changes Feb 6, 2023
View reviewed changes
schadii
schadii previously approved these changes Feb 6, 2023
View reviewed changes
@SGrueber
Copy link
Collaborator

SGrueber commented Feb 6, 2023 •
edited
Loading

The logout link has been moved from the top to the bottom. If the organization menu is open it looks like an organization item ?

image

@SGrueber
Copy link
Collaborator

SGrueber commented Feb 6, 2023

Why is payment under MyOrganization. Aren't payment instruments, like credit cards etc. specific to the user?

@SGrueber
Copy link
Collaborator

SGrueber commented Feb 6, 2023

The My Organization menu item is empty for a punchout user and should not be visible.

image

@SGrueber SGrueber dismissed stale reviews from schadii and iwiederhold via e857473 February 8, 2023 11:07
@SGrueber SGrueber requested review from SGrueber and removed request for SGrueber February 8, 2023 11:43
SGrueber
SGrueber previously approved these changes Feb 8, 2023
View reviewed changes
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

Azure Demo Servers are available:

schadii
schadii previously approved these changes Feb 8, 2023
View reviewed changes
Copy link

@schadii schadii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

iwiederhold
iwiederhold previously approved these changes Feb 8, 2023
View reviewed changes
Copy link

@iwiederhold iwiederhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shauke shauke dismissed stale reviews from iwiederhold, schadii, and SGrueber via 49ff1a3 February 13, 2023 16:46
@shauke shauke force-pushed the feature-my_Account_menu_navigation_grouping branch from 49ff1a3 to acd37f2 Compare February 20, 2023 18:06
@shauke shauke force-pushed the feature-my_Account_menu_navigation_grouping branch from acd37f2 to ef20961 Compare February 22, 2023 14:59
@shauke shauke merged commit 3334e77 into develop Feb 23, 2023
@shauke shauke deleted the feature-my_Account_menu_navigation_grouping branch February 23, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shauke shauke shauke approved these changes

@schadii schadii schadii left review comments

@SGrueber SGrueber SGrueber left review comments

@iwiederhold iwiederhold iwiederhold left review comments

Assignees

@shauke shauke

Labels
enhancement Enhancement to an existing feature has conflicts
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@tdonthu @SGrueber @shauke @iwiederhold @schadii @5t3v3n-H